On 21/11/2024 11:51, Jason-JH Lin (林睿祥) wrote: >>> Signed-off-by: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx> >>> --- >>> .../dt-bindings/mailbox/mediatek,mt8196-gce.h | 1449 >>> +++++++++++++++++ >>> 1 file changed, 1449 insertions(+) >>> create mode 100755 include/dt-bindings/mailbox/mediatek,mt8196- >>> gce.h >> >> Please run scripts/checkpatch.pl and fix reported warnings. Then >> please >> run 'scripts/checkpatch.pl --strict' and (probably) fix more >> warnings. >> Some warnings can be ignored, especially from --strict run, but the >> code >> here looks like it needs a fix. Feel free to get in touch if the >> warning >> is not clear. >> >> This goes with the binding. >> > > I thought I have done that, but I found a whitespace warning at #1328 > now. I'll fix that at the next version. > Thanks for the reminder. There are multiple errors, including executable permission. I don't believe you run checkpatch. Best regards, Krzysztof