On Thu, Nov 21, 2024 at 12:25:55PM +0800, Jason-JH.Lin wrote: > Add the Global Command Engine (GCE) header file to define the GCE > thread priority, GCE subsys ID, GCE events, and various constants > for MT8196. NAK, various constants are not bindings. > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx> > --- > .../dt-bindings/mailbox/mediatek,mt8196-gce.h | 1449 +++++++++++++++++ > 1 file changed, 1449 insertions(+) > create mode 100755 include/dt-bindings/mailbox/mediatek,mt8196-gce.h Please run scripts/checkpatch.pl and fix reported warnings. Then please run 'scripts/checkpatch.pl --strict' and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. This goes with the binding. Best regards, Krzysztof