On 19/07/2023 11:29, Viktar Simanenka wrote: > On 2023-07-18 08:35, Krzysztof Kozlowski wrote: >> Bindings are always separate patches. >> Please run scripts/checkpatch.pl and fix reported warnings. > > Added vendor-prefix to fix warning. > >>> + inverted: >>> + maxItems: 1 >>> + description: Invert display colors >> You described the desired Linux feature or behavior, not the actual >> hardware. The bindings are about the latter, so instead you need to >> rephrase the property and its description to match actual hardware >> capabilities/features/configuration etc. > > revised the descriptions and added suitable types according to the > documentation > >> Please run `make dt_binding_check` (see >> Documentation/devicetree/bindings/writing-schema.rst for instructions). >> Maybe you need to update your dtschema and yamllint. > > cleaned up unneccessary fields (leftovers) from tested binding > > On 2023-07-18 9:19, Rob Herring wrote: >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date >> Please check and re-submit after running the above command yourself. > > upgraded dtschema and found all the warnings. thanks. seems to be fixed > > Signed-off-by: Viktar Simanenka <viteosen@xxxxxxxxx> No clue what is this - is it a reply or new patch to review... does not look like the latter, so I will just skip it. Please version your patches, provide changelog and send proper patchsets. Best regards, Krzysztof
