On Tue, 18 Jul 2023 11:07:27 +0300, Viktar Simanenka wrote: > Support for common monochrome LCD displays based on PCD8544 (such as Nokia 5110/3310 LCD) SPI controlled displays. > > Signed-off-by: Viktar Simanenka <viteosen@xxxxxxxxx> > --- > .../bindings/display/philips,pcd8544.yaml | 92 ++++ > drivers/gpu/drm/tiny/Kconfig | 11 + > drivers/gpu/drm/tiny/pcd8544.c | 506 ++++++++++++++++++ > 3 files changed, 609 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/philips,pcd8544.yaml > create mode 100644 drivers/gpu/drm/tiny/pcd8544.c > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/display/philips,pcd8544.example.dts:21.13-23: Warning (reg_format): /example-0/display@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) Documentation/devicetree/bindings/display/philips,pcd8544.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/display/philips,pcd8544.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/display/philips,pcd8544.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/display/philips,pcd8544.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/display/philips,pcd8544.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/philips,pcd8544.example.dtb: display@0: Unevaluated properties are not allowed ('write-only' was unexpected) from schema $id: http://devicetree.org/schemas/display/philips,pcd8544.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230718080727.323426-1-viteosen@xxxxxxxxx The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.