On 2023-07-18 08:35, Krzysztof Kozlowski wrote: > Bindings are always separate patches. > Please run scripts/checkpatch.pl and fix reported warnings. Added vendor-prefix to fix warning. > > + inverted: > > + maxItems: 1 > > + description: Invert display colors > You described the desired Linux feature or behavior, not the actual > hardware. The bindings are about the latter, so instead you need to > rephrase the property and its description to match actual hardware > capabilities/features/configuration etc. revised the descriptions and added suitable types according to the documentation > Please run `make dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Maybe you need to update your dtschema and yamllint. cleaned up unneccessary fields (leftovers) from tested binding On 2023-07-18 9:19, Rob Herring wrote: > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date > Please check and re-submit after running the above command yourself. upgraded dtschema and found all the warnings. thanks. seems to be fixed Signed-off-by: Viktar Simanenka <viteosen@xxxxxxxxx> --- .../bindings/display/philips,pcd8544.yaml | 89 +++++++++++++++++++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + 2 files changed, 91 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/philips,pcd8544.yaml diff --git a/Documentation/devicetree/bindings/display/philips,pcd8544.yaml b/Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file mode 100644 index 000000000000..ac880d9d8cc1 --- /dev/null +++ b/Documentation/devicetree/bindings/display/philips,pcd8544.yaml @@ -0,0 +1,89 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/philips,pcd8544.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Philips PCD8544 LCD Display Controller + +maintainers: + - Viktar Simanenka <viteosen@xxxxxxxxx> + +description: | + Philips PCD8544 LCD Display Controller with SPI control bus. + Monochrome 84x48 LCD displays, such as Nokia 5110/3310 LCDs. + May contain backlight LED. + +allOf: + - $ref: panel/panel-common.yaml# + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +properties: + compatible: + oneOf: + - enum: + - philips,pcd8544 + + dc-gpios: + maxItems: 1 + description: Data/Command selection pin (D/CX) + + reset-gpios: + maxItems: 1 + description: Display Reset pin (RST) + + philips,inverted: + type: boolean + description: Display color inversion + + philips,voltage-op: + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 127 + description: Display liquid crystal operation voltage + + philips,bias: + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 7 + description: Display bias voltage system value + + philips,temperature-coeff: + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3 + description: Display temperature compensation coefficient + +required: + - compatible + - reg + - dc-gpios + - reset-gpios + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + spi { + #address-cells = <1>; + #size-cells = <0>; + + display@0 { + compatible = "philips,pcd8544"; + spi-max-frequency = <8000000>; + reg = <0>; + + dc-gpios = <&pio 0 3 GPIO_ACTIVE_HIGH>; /* DC=PA3 */ + reset-gpios = <&pio 0 1 GPIO_ACTIVE_HIGH>; /* RESET=PA1 */ + backlight = <&backlight>; + + philips,inverted; + philips,voltage-op = <0>; + philips,bias = <4>; + philips,temperature-coeff = <0>; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index af60bf1a6664..0c3844af6776 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -1037,6 +1037,8 @@ patternProperties: description: Pervasive Displays, Inc. "^phicomm,.*": description: PHICOMM Co., Ltd. + "^philips,.*": + description: Koninklijke Philips N.V. "^phytec,.*": description: PHYTEC Messtechnik GmbH "^picochip,.*": -- 2.34.1
