Hi Sam, On Sun, Nov 29, 2020 at 12:18:36PM +0100, Sam Ravnborg wrote: > On Sun, Nov 29, 2020 at 07:28:08PM +0900, Tetsuo Handa wrote: > > But replacing printk(KERN_DEBUG) with pr_debug() prevents __func__ from being printed > > when FBCONDEBUG is defined. Is such change what the author of this module expects? > > When someone goes and enable DEBUG for fbcon they are also able to > recognize the logging, so the printing of the function name is redundant > in this case. > > There is likely limited to no use for these few logging entries, but if > they should be dropped then I expect Peilin Ye to do so as he is the > only one doing active maintenance of fbcon lately. Sure, I will take another look at them. Also sorry for the delay in that printk() -> dev_*() patch you suggested, overwhelmed by some other things this week. Sometimes fbcon.c accesses dev structs in a pretty weird way (e.g. registered_fb[con2fb_map[vc->vc_num]]->dev), I will get back to it when I understand this better. Thanks, Peilin Ye _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
