Following the great work of Lee Jones in other subsystems
here is a set of patches that address all remaining W=1
warnings in drivers/video/.
Lee Jones already fixed all warnings in video/backlight/ so
this is mostly fbdev related fixes.
The general approach used were:
- Fix kernel-doc, this is often very trivial
- Drop unused local variables
- Use no_printk for local logging support
Build tested on a set of architectures with various configs.
The patches do not depends on each other and in most cases all
fixes for one driver is kept in a single patch.
The individual changes are trivial so this is a great
starter task to try to review these patches.
A timely Reviewed-by: or Acked-by: would be very nice so we can
get the warnings fixes before we cut for the merge window.
v2:
- Updated subject of the patches to tell what was fixed (Lee)
- Fixed build error in one patch (kernel test robot)
- A few editorials updates to the changelog messages
Sam
Sam Ravnborg (28):
video: Fix kernel-doc warnings in of_display_timing + of_videomode
video: fbcon: Fix warnings by using pr_debug() in fbcon
video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify
video: fbdev: aty: Delete unused variable in radeon_monitor
video: fbdev: aty: Fix set but not used warnings
video: fbdev: aty: Fix set but not used warnings in mach64_ct
video: fbdev: sis: Fix defined but not used warnings
video: fbdev: sis: Fix defined but not used warning of SiS_TVDelay
video: fbdev: sis: Fix set but not used warnings in init.c
video: fbdev: sis: Fix set but not used warnings in sis_main
video: fbdev: via: Fix set but not used warning for mode_crt_table
video: fbdev: tdfx: Fix set but not used warning in att_outb()
video: fbdev: riva: Fix kernel-doc and set but not used warnings
video: fbdev: pm2fb: Fix kernel-doc warnings
video: fbdev: neofb: Fix set but not used warning for CursorMem
video: fbdev: hgafb: Fix kernel-doc warnings
video: fbdev: tgafb: Fix kernel-doc and set but not used warnings
video: fbdev: mx3fb: Fix kernel-doc, set but not used and string warnings
video: fbdev: sstfb: Updated logging to fix set but not used warnings
video: fbdev: nvidia: Fix set but not used warnings
video: fbdev: tmiofb: Fix set but not used warnings
video: fbdev: omapfb: Fix set but not used warnings in dsi
video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core
video: fbdev: s3c-fb: Fix kernel-doc and set but not used warnings
video: fbdev: uvesafb: Fix set but not used warning
video: fbdev: uvesafb: Fix string related warnings
video: fbdev: cirrusfb: Fix kernel-doc and set but not used warnings
video: fbdev: s1d13xxxfb: Fix kernel-doc and set but not used warnings
drivers/video/fbdev/aty/atyfb_base.c | 11 +++-----
drivers/video/fbdev/aty/mach64_ct.c | 15 ++++++----
drivers/video/fbdev/aty/radeon_monitor.c | 4 +--
drivers/video/fbdev/cirrusfb.c | 20 ++++++-------
drivers/video/fbdev/core/fb_notify.c | 3 +-
drivers/video/fbdev/core/fbcon.c | 25 ++++++-----------
drivers/video/fbdev/core/fbmon.c | 2 +-
drivers/video/fbdev/hgafb.c | 4 +--
drivers/video/fbdev/mx3fb.c | 13 +++++----
drivers/video/fbdev/neofb.c | 4 ---
drivers/video/fbdev/nvidia/nv_setup.c | 7 ++---
drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 12 ++------
drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c | 4 +--
drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 4 +--
drivers/video/fbdev/pm2fb.c | 8 +++---
drivers/video/fbdev/riva/fbdev.c | 9 +++---
drivers/video/fbdev/riva/riva_hw.c | 28 ++++++-------------
drivers/video/fbdev/s1d13xxxfb.c | 3 +-
drivers/video/fbdev/s3c-fb.c | 11 ++++----
drivers/video/fbdev/sis/init.c | 34 ++++-------------------
drivers/video/fbdev/sis/oem310.h | 2 ++
drivers/video/fbdev/sis/sis.h | 1 -
drivers/video/fbdev/sis/sis_main.c | 9 +++---
drivers/video/fbdev/sstfb.c | 2 +-
drivers/video/fbdev/tdfxfb.c | 4 +--
drivers/video/fbdev/tgafb.c | 7 ++---
drivers/video/fbdev/tmiofb.c | 6 ++--
drivers/video/fbdev/uvesafb.c | 8 +++---
drivers/video/fbdev/via/lcd.c | 4 +--
drivers/video/of_display_timing.c | 1 +
drivers/video/of_videomode.c | 8 +++---
include/video/sstfb.h | 4 +--
32 files changed, 107 insertions(+), 170 deletions(-)
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
