Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020/11/29 19:03, Thomas Zimmermann wrote:
> Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
>> Replacing DPRINTK() statements with pr_debug fixes set but not used
>> warnings.  And moves to a more standard logging setup at the same time.
> 
> I guess this was added for quick debugging during development. Anyway, I never liked these kinds of hacks.
> 
> Acked-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> 

But replacing printk(KERN_DEBUG) with pr_debug() prevents __func__ from being printed
when FBCONDEBUG is defined. Is such change what the author of this module expects?
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux