Re: [PATCH 1/2] dt-bindings: add binding for Ilitek ili9486 based display panels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Den 25.01.2020 16.38, skrev Kamlesh Gurudasani:
> Signed-off-by: Kamlesh Gurudasani <kamlesh.gurudasani@xxxxxxxxx>
> ---
>  .../devicetree/bindings/display/ilitek,ili9486.txt | 27 ++++++++++++++++++++++

For version 2, send the patchset to the devicetree mailinglist as well.
A DT maintainer has to review it. Send the whole set since he wants to
look at the driver as well.

See: Documentation/devicetree/bindings/submitting-patches.txt

Looks like bindings are in yaml format now.

>  1 file changed, 27 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9486.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/ilitek,ili9486.txt b/Documentation/devicetree/bindings/display/ilitek,ili9486.txt
> new file mode 100644
> index 0000000..51c8196
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/ilitek,ili9486.txt
> @@ -0,0 +1,27 @@
> +Ilitek ILI9486 display panels
> +
> +This binding is for display panels using an Ilitek ILI9486 controller in SPI
> +mode.
> +
> +Required properties:
> +- compatible:   "ozzmaker,piscreen", "waveshare,rpi-lcd-35", "ilitek,ili9486"

Drop the last entry since it doesn't make any sense since the controller
won't work without being initialized (it would make sense if we could
read out from the controller which panel is connected). And the driver
doesn't support this compatible either.

I assume that ozzmaker and waveshare needs to be added to
bindings/vendor-prefixes.yaml, and that would be as a separate patch.

> +- dc-gpios:     D/C pin
> +- reset-gpios:  Reset pin

Both these are optional in the driver.

> +
> +The node for this driver must be a child node of a SPI controller, hence
> +all mandatory properties described in ../spi/spi-bus.txt must be specified.
> +
> +Optional properties:
> +- rotation:     panel rotation in degrees counter clockwise (0,90,180,270)
> +- backlight:    phandle of the backlight device attached to the panel
> +
> +Example:
> +        display@0{
> +                compatible = "ozzmaker,piscreen", "waveshare,rpi-lcd-35", "ilitek,ili9486";

Pick only one compatible for the example.

Noralf.

> +                reg = <0>;
> +                spi-max-frequency = <32000000>;
> +                dc-gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>;
> +                reset-gpios = <&gpio0 8 GPIO_ACTIVE_HIGH>;
> +                rotation = <180>;
> +                backlight = <&backlight>;
> +        };
> 
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux