Hi Geert,
Thanks for the feedback
> Subject: Re: [PATCH v2 1/2] dmaengine: sh: rz-dmac: Add
> device_synchronize callback
>
> On Tue, Jul 19, 2022 at 5:00 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > Some on-chip peripheral modules(for eg:- rspi) on RZ/G2L SoC use the
> > same signal for both interrupt and DMA transfer requests.
> > The signal works as a DMA transfer request signal by setting DMARS,
> > and subsequent interrupt requests to the interrupt controller are
> > masked.
> >
> > We can enable the interrupt by clearing the DMARS.
>
> re-enable?
OK.
>
> >
> > This patch adds device_synchronize callback for clearing DMARS and
> > thereby allowing DMA consumers to switch to DMA mode.
>
> interrupt mode
OK. Will fix this in v2.
Cheers,
Biju
>
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v1->v2:
> > * No change
>
> With the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
> -- Linus Torvalds
