RE: [PATCH v2 1/2] dmaengine: sh: rz-dmac: Add device_synchronize callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH v2 1/2] dmaengine: sh: rz-dmac: Add
> device_synchronize callback
> 
> Hi Biju,
> 
> On Thu, Jul 21, 2022 at 11:47 AM Geert Uytterhoeven <geert@linux-
> m68k.org> wrote:
> > On Tue, Jul 19, 2022 at 5:00 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > > Some on-chip peripheral modules(for eg:- rspi) on RZ/G2L SoC use the
> > > same signal for both interrupt and DMA transfer requests.
> > > The signal works as a DMA transfer request signal by setting DMARS,
> > > and subsequent interrupt requests to the interrupt controller are
> > > masked.
> > >
> > > We can enable the interrupt by clearing the DMARS.
> >
> > re-enable?
> >
> > >
> > > This patch adds device_synchronize callback for clearing DMARS and
> > > thereby allowing DMA consumers to switch to DMA mode.
> >
> > interrupt mode
> >
> > >
> > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > > ---
> > > v1->v2:
> > >  * No change
> >
> > With the above fixed:
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> 
> > > +static void rz_dmac_device_synchronize(struct dma_chan *chan) {
> > > +       struct rz_dmac_chan *channel = to_rz_dmac_chan(chan);
> > > +       struct rz_dmac *dmac = to_rz_dmac(chan->device);
> > > +
> 
> Actually this should check if the DMA operation has been completed or
> terminated, and wait (sleep) if needed.

OK will send v3 with these changes.

Cheers,
Biju





[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux