On Tue, May 08 2007, Andrew Morton wrote:
> > static inline void bio_list_init(struct bio_list *bl)
> > {
> > bl->head = bl->tail = NULL;
> > }
> >
> > +#define bio_list_for_each(bio, bl) \
> > + for (bio = (bl)->head; bio && ({ prefetch(bio->bi_next); 1; }); \
> > + bio = bio->bi_next)
> > +
>
> I have this vague memory from a long time ago that one particular CPU type
> wants to go oops when prefetching from an invalid address.
>
> Maybe that went away for some reason - we'd have hit it again if it was
> real.
Besides, manual prefetching is very rarely a win. I dabbled with some
benchmarks a few weeks back (with the doubly linked lists), and in most
cases it was actually a loss. So I'd vote for just removing the
prefetch() above.
--
Jens Axboe
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
