On May 9 2007 08:49, Jens Axboe wrote: >On Tue, May 08 2007, Andrew Morton wrote: >> > +#define bio_list_for_each(bio, bl) \ >> > + for (bio = (bl)->head; bio && ({ prefetch(bio->bi_next); 1; }); \ >> > + bio = bio->bi_next) >> > + > >Besides, manual prefetching is very rarely a win. I dabbled with some >benchmarks a few weeks back (with the doubly linked lists), and in most >cases it was actually a loss. So I'd vote for just removing the >prefetch() above. So is the prefetching in the basic ADTs (e.g. linux/list.h) a loss too? Jan -- -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel