The patchset adds a new driver for Samsung AMS427AP24 panel with S6E88A0 controller. Patches are based on current branch drm-misc-next. The discussion in v3 was not finished. I send v4 nonetheless as a new base to continue the discussion. I hope that's ok. Changes in v4: Patch 3 - Removed include <linux/of.h>, it's not needed. - Added comments to the mipi_dsi_dcs_write_seq_multi() lines in function s6e88a0_ams427ap24_on(). Patch 4 - New defines for payload data length, thereof a fixed and a variable part. - In the array s6e88a0_ams427ap24_br_to_cd[] made the comment about the columns more clear and added an additional column "brightness from". - Array s6e88a0_ams427ap24_aid[] reduced from five to two columns and s6e88a0_ams427ap24_elvss[] from two to one column. Now they hold the variable data only. I kept s6e88a0_ams427ap24_elvss[] as a two-dimensional array to allow using the same memcopy procedure for all three buffers aid, elvss and gamma in function s6e88a0_ams427ap24_set_brightness(). - In function s6e88a0_ams427ap24_set_brightness() initialized prototype payload array for b2 and b6 commands. And in the memcpy commands below used the new defines for the fixed and variable data length. Patch 5 - Added a comment to the mipi_dsi_dcs_write_seq_multi() line, according to the other lines before and after. v1: https://lore.kernel.org/dri-devel/cover.1728582727.git.jahau@xxxxxxxxxxxxxx/T/#t v2: https://lore.kernel.org/dri-devel/cover.1729630039.git.jahau@xxxxxxxxxxxxxx/T/#t v3: https://lore.kernel.org/dri-devel/cover.1729738189.git.jahau@xxxxxxxxxxxxxx/T/#t Jakob Hauser (5): dt-bindings: display: panel: Move flip properties to panel-common dt-bindings: display: panel: Add Samsung S6E88A0-AMS427AP24 drm/panel: samsung-s6e88a0-ams427ap24: Add initial driver drm/panel: samsung-s6e88a0-ams427ap24: Add brightness control drm/panel: samsung-s6e88a0-ams427ap24: Add flip option .../bindings/display/panel/panel-common.yaml | 8 + .../panel/samsung,s6e88a0-ams427ap24.yaml | 65 ++ .../display/panel/samsung,s6e8aa0.yaml | 10 +- drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel/Makefile | 1 + .../panel/panel-samsung-s6e88a0-ams427ap24.c | 766 ++++++++++++++++++ 6 files changed, 852 insertions(+), 8 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams427ap24.yaml create mode 100644 drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c -- 2.39.5
