> -----Original Message----- > From: Frank Li <frank.li@xxxxxxx> > Sent: 2024年10月10日 23:17 > To: Wei Fang <wei.fang@xxxxxxx> > Cc: Rob Herring <robh@xxxxxxxxxx>; davem@xxxxxxxxxxxxx; > edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; > krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; Vladimir Oltean > <vladimir.oltean@xxxxxxx>; Claudiu Manoil <claudiu.manoil@xxxxxxx>; Clark > Wang <xiaoning.wang@xxxxxxx>; christophe.leroy@xxxxxxxxxx; > linux@xxxxxxxxxxxxxxx; bhelgaas@xxxxxxxxxx; imx@xxxxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx > Subject: Re: [PATCH net-next 02/11] dt-bindings: net: add i.MX95 ENETC support > > On Thu, Oct 10, 2024 at 02:14:50AM +0000, Wei Fang wrote: > > > -----Original Message----- > > > From: Rob Herring <robh@xxxxxxxxxx> > > > Sent: 2024年10月10日 4:53 > > > To: Frank Li <frank.li@xxxxxxx> > > > Cc: Wei Fang <wei.fang@xxxxxxx>; davem@xxxxxxxxxxxxx; > > > edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; > > > krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; Vladimir Oltean > > > <vladimir.oltean@xxxxxxx>; Claudiu Manoil <claudiu.manoil@xxxxxxx>; > Clark > > > Wang <xiaoning.wang@xxxxxxx>; christophe.leroy@xxxxxxxxxx; > > > linux@xxxxxxxxxxxxxxx; bhelgaas@xxxxxxxxxx; imx@xxxxxxxxxxxxxxx; > > > netdev@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > > > linux-kernel@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx > > > Subject: Re: [PATCH net-next 02/11] dt-bindings: net: add i.MX95 ENETC > support > > > > > > On Wed, Oct 09, 2024 at 12:29:57PM -0400, Frank Li wrote: > > > > On Wed, Oct 09, 2024 at 05:51:07PM +0800, Wei Fang wrote: > > > > > The ENETC of i.MX95 has been upgraded to revision 4.1, and the vendor > > > > > ID and device ID have also changed, so add the new compatible strings > > > > > for i.MX95 ENETC. In addition, i.MX95 supports configuration of RGMII > > > > > or RMII reference clock. > > > > > > > > > > Signed-off-by: Wei Fang <wei.fang@xxxxxxx> > > > > > --- > > > > > .../devicetree/bindings/net/fsl,enetc.yaml | 23 > +++++++++++++++---- > > > > > 1 file changed, 19 insertions(+), 4 deletions(-) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/net/fsl,enetc.yaml > > > b/Documentation/devicetree/bindings/net/fsl,enetc.yaml > > > > > index e152c93998fe..1a6685bb7230 100644 > > > > > --- a/Documentation/devicetree/bindings/net/fsl,enetc.yaml > > > > > +++ b/Documentation/devicetree/bindings/net/fsl,enetc.yaml > > > > > @@ -20,14 +20,29 @@ maintainers: > > > > > > > > > > properties: > > > > > compatible: > > > > > - items: > > > > > - - enum: > > > > > - - pci1957,e100 > > > > > - - const: fsl,enetc > > > > > + oneOf: > > > > > + - items: > > > > > + - enum: > > > > > + - pci1957,e100 > > > > > + - const: fsl,enetc > > > > > + - items: > > > > > + - const: pci1131,e101 > > > > > + - items: > > > > > + - enum: > > > > > + - nxp,imx95-enetc > > > > > + - const: pci1131,e101 > > > > > > > > oneOf: > > > > - items: > > > > - enum: > > > > - pci1957,e100 > > > > - const: fsl,enetc > > > > - items: > > > > - const: pci1131,e101 > > > > - enum: > > > > - nxp,imx95-enetc > > > > > > const. > > > > > > Or maybe just drop it. Hopefully the PCI ID changes with each chip. If > > > not, we kind of have the compatibles backwards. > > > > I am pretty sure that the device ID will not change in later chips unless > > the functionality of the ENETC is different. > > It is quite weird for PCIe devices. Device ID, at least Reversion ID should > change. At least, I have not see use "nxp,imx95-enetc" at driver code. > Yes, the "nxp,imx95-enetc" is not used in the driver yet, I just referred to "fsl,enetc". I think I can remove it in the next version. Thanks. > > > > > > > > minItems: 1 > > > > > > Then why have the fallback?
