> -----Original Message----- > From: Frank Li <frank.li@xxxxxxx> > Sent: 2024年10月10日 0:30 > To: Wei Fang <wei.fang@xxxxxxx> > Cc: davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; > pabeni@xxxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; > conor+dt@xxxxxxxxxx; Vladimir Oltean <vladimir.oltean@xxxxxxx>; Claudiu > Manoil <claudiu.manoil@xxxxxxx>; Clark Wang <xiaoning.wang@xxxxxxx>; > christophe.leroy@xxxxxxxxxx; linux@xxxxxxxxxxxxxxx; bhelgaas@xxxxxxxxxx; > imx@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx > Subject: Re: [PATCH net-next 02/11] dt-bindings: net: add i.MX95 ENETC support > > On Wed, Oct 09, 2024 at 05:51:07PM +0800, Wei Fang wrote: > > The ENETC of i.MX95 has been upgraded to revision 4.1, and the vendor > > ID and device ID have also changed, so add the new compatible strings > > for i.MX95 ENETC. In addition, i.MX95 supports configuration of RGMII > > or RMII reference clock. > > > > Signed-off-by: Wei Fang <wei.fang@xxxxxxx> > > --- > > .../devicetree/bindings/net/fsl,enetc.yaml | 23 +++++++++++++++---- > > 1 file changed, 19 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/fsl,enetc.yaml > > b/Documentation/devicetree/bindings/net/fsl,enetc.yaml > > index e152c93998fe..1a6685bb7230 100644 > > --- a/Documentation/devicetree/bindings/net/fsl,enetc.yaml > > +++ b/Documentation/devicetree/bindings/net/fsl,enetc.yaml > > @@ -20,14 +20,29 @@ maintainers: > > > > properties: > > compatible: > > - items: > > - - enum: > > - - pci1957,e100 > > - - const: fsl,enetc > > + oneOf: > > + - items: > > + - enum: > > + - pci1957,e100 > > + - const: fsl,enetc > > + - items: > > + - const: pci1131,e101 > > + - items: > > + - enum: > > + - nxp,imx95-enetc > > + - const: pci1131,e101 > > oneOf: > - items: > - enum: > - pci1957,e100 > - const: fsl,enetc > - items: > - const: pci1131,e101 > - enum: > - nxp,imx95-enetc > minItems: 1 > > keep consistent, pid/did as first one. > I think it's better to put enum before const, and minItems does not seem to be placed here. > > > > > reg: > > maxItems: 1 > > > > + clocks: > > + items: > > + - description: MAC transmit/receiver reference clock > > + > > + clock-names: > > + items: > > + - const: enet_ref_clk > > + > > mdio: > > $ref: mdio.yaml > > unevaluatedProperties: false > > -- > > 2.34.1 > >
