On Sat, 21 Sept 2024 at 00:25, Rob Clark <robdclark@xxxxxxxxx> wrote: > > On Thu, Sep 19, 2024 at 10:01 AM Aleksandrs Vinarskis > <alex.vinarskis@xxxxxxxxx> wrote: > > > > Initial support for Dell XPS 9345 13" 2024 (Tributo) based on X1E80100. > > > > Working: > > * Touchpad > > * Keyboard (only post suspend&resume, i2c-hid patch WIP) > > * eDP, with brightness control > > * NVME > > * USB Type-C ports in USB2/USB3 (one orientation) > > * WiFi > > * GPU/aDSP/cDSP firmware loading (requires binaries from Windows) > > * Lid switch > > * Sleep/suspend, nothing visibly broken on resume > > > > Not working: > > * Speakers (WIP, pin guessing, x4 WSA8845) > > * Microphones (WIP, pin guessing) > > * Fingerprint Reader (WIP, USB MP with ptn3222) > > * USB as DP/USB3 (WIP, PS8830 based) > > * Camera > > * Battery Info > > > > Should be working, but cannot be tested due to lack of hw: > > * Higher res OLED, higher res IPS panels > > My suspicion is that OLED vs IPS will require different dtb. I'm > expecting the OLED to use samsung,atna33xc20 panel driver (see "arm64: > dts: qcom: x1e80100-yoga: Update panel bindings"), but IPS can > probably use edp-panel. I'm not sure if anyone has gotten both panels > working on any other device that has both IPS and OLED variants, so > this remains a theory. The t14s, which also has both IPS and OLED, > has different DMI/CHID values for the different SKUs, so DtbLoader > should be able to pick the correct dtb, once it exists. Thanks for the input. Will take a look at that driver. I have briefly looked into .inf from Dell's Windows driver trying to identify them - all three panels have dell-specific model naming, which unfortunately does not help much. As far as I found from unofficial sources (1), the particular OLED is LG made, not Samsung. Luckily, Peter de Kraker (CCed) has reached out to me yesterday as he got an OLED variant - will test on his machine in the following weeks, as well as record CHIDs once he is able to boot with a working display. Sounds rather unscalable though if each variant of laptop would need a separate dtb? Eg. Dell's Inspiron model supports both x1e80 and x1e78 (luckily no OLEDs though). If some OEM would release a model with both displays and SoCs customizable, the number of variants would grow pretty fast... [1] https://www.thelec.net/news/articleView.html?idxno=4858 Alex > > BR, > -R > > > * Touchscreen > > > > Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@xxxxxxxxx> > > --- > > arch/arm64/boot/dts/qcom/Makefile | 1 + > > .../dts/qcom/x1e80100-dell-tributo-13.dts | 860 ++++++++++++++++++ > > 2 files changed, 861 insertions(+) > > create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-dell-tributo-13.dts > > > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > > index ae002c7cf126..111c589d6bae 100644 > > --- a/arch/arm64/boot/dts/qcom/Makefile > > +++ b/arch/arm64/boot/dts/qcom/Makefile > > @@ -271,6 +271,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb > > dtb-$(CONFIG_ARCH_QCOM) += x1e78100-lenovo-thinkpad-t14s.dtb > > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-asus-vivobook-s15.dtb > > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-crd.dtb > > +dtb-$(CONFIG_ARCH_QCOM) += x1e80100-dell-tributo-13.dtb > > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-lenovo-yoga-slim7x.dtb > > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-microsoft-romulus13.dtb > > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-microsoft-romulus15.dtb > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-tributo-13.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-tributo-13.dts > > new file mode 100644 > > index 000000000000..d387f133c398 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-tributo-13.dts > > @@ -0,0 +1,860 @@ > > +// SPDX-License-Identifier: BSD-3-Clause > > +/* > > + * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved. > > + * Copyright (c) 2024 Aleksandrs Vinarskis <alex.vinarskis@xxxxxxxxx> > > + */ > > + > > +/dts-v1/; > > + > > +#include <dt-bindings/gpio/gpio.h> > > +#include <dt-bindings/input/gpio-keys.h> > > +#include <dt-bindings/input/input.h> > > +#include <dt-bindings/leds/common.h> > > +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> > > + > > +#include "x1e80100.dtsi" > > +#include "x1e80100-pmics.dtsi" > > + > > +/ { > > + model = "Dell XPS 13 9345"; > > + compatible = "dell,tributo-13", "qcom,x1e80100"; > > + chassis-type = "laptop"; > > + > > + gpio-keys { > > + compatible = "gpio-keys"; > > + > > + pinctrl-0 = <&hall_int_n_default>; > > + pinctrl-names = "default"; > > + > > + switch-lid { > > + gpios = <&tlmm 92 GPIO_ACTIVE_LOW>; > > + linux,input-type = <EV_SW>; > > + linux,code = <SW_LID>; > > + wakeup-source; > > + wakeup-event-action = <EV_ACT_DEASSERTED>; > > + }; > > + }; > > + > > + leds { > > + compatible = "gpio-leds"; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&cam_indicator_en>; > > + > > + led-camera-indicator { > > + label = "white:camera-indicator"; > > + function = LED_FUNCTION_INDICATOR; > > + color = <LED_COLOR_ID_WHITE>; > > + gpios = <&tlmm 110 GPIO_ACTIVE_HIGH>; > > + linux,default-trigger = "none"; > > + default-state = "off"; > > + /* Reuse as a panic indicator until we get a "camera on" trigger */ > > + panic-indicator; > > + }; > > + }; > > + > > + pmic-glink { > > + compatible = "qcom,x1e80100-pmic-glink", > > + "qcom,sm8550-pmic-glink", > > + "qcom,pmic-glink"; > > + orientation-gpios = <&tlmm 121 GPIO_ACTIVE_HIGH>, > > + <&tlmm 123 GPIO_ACTIVE_HIGH>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + /* Right-side USB Type-C port */ > > + connector@0 { > > + compatible = "usb-c-connector"; > > + reg = <0>; > > + power-role = "dual"; > > + data-role = "dual"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + > > + pmic_glink_ss0_hs_in: endpoint { > > + remote-endpoint = <&usb_1_ss0_dwc3_hs>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + > > + pmic_glink_ss0_ss_in: endpoint { > > + remote-endpoint = <&usb_1_ss0_qmpphy_out>; > > + }; > > + }; > > + }; > > + }; > > + > > + /* Left-side USB Type-C port */ > > + connector@1 { > > + compatible = "usb-c-connector"; > > + reg = <1>; > > + power-role = "dual"; > > + data-role = "dual"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + > > + pmic_glink_ss1_hs_in: endpoint { > > + remote-endpoint = <&usb_1_ss1_dwc3_hs>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + > > + pmic_glink_ss1_ss_in: endpoint { > > + remote-endpoint = <&usb_1_ss1_qmpphy_out>; > > + }; > > + }; > > + }; > > + }; > > + }; > > + > > + reserved-memory { > > + linux,cma { > > + compatible = "shared-dma-pool"; > > + size = <0x0 0x8000000>; > > + reusable; > > + linux,cma-default; > > + }; > > + }; > > + > > + vph_pwr: vph-pwr-regulator { > > + compatible = "regulator-fixed"; > > + > > + regulator-name = "vph_pwr"; > > + regulator-min-microvolt = <3700000>; > > + regulator-max-microvolt = <3700000>; > > + > > + regulator-always-on; > > + regulator-boot-on; > > + }; > > + > > + vreg_edp_3p3: regulator-edp-3p3 { > > + compatible = "regulator-fixed"; > > + > > + regulator-name = "VREG_EDP_3P3"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + > > + gpio = <&tlmm 70 GPIO_ACTIVE_HIGH>; > > + enable-active-high; > > + > > + pinctrl-0 = <&edp_reg_en>; > > + pinctrl-names = "default"; > > + > > + regulator-boot-on; > > + }; > > + > > + vreg_nvme: regulator-nvme { > > + compatible = "regulator-fixed"; > > + > > + regulator-name = "VREG_NVME_3P3"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + > > + gpio = <&tlmm 18 GPIO_ACTIVE_HIGH>; > > + enable-active-high; > > + > > + pinctrl-0 = <&nvme_reg_en>; > > + pinctrl-names = "default"; > > + }; > > +}; > > + > > +&apps_rsc { > > + regulators-0 { > > + compatible = "qcom,pm8550-rpmh-regulators"; > > + qcom,pmic-id = "b"; > > + vdd-bob1-supply = <&vph_pwr>; > > + vdd-bob2-supply = <&vph_pwr>; > > + vdd-l1-l4-l10-supply = <&vreg_s4c_1p8>; > > + vdd-l2-l13-l14-supply = <&vreg_bob1>; > > + vdd-l5-l16-supply = <&vreg_bob1>; > > + vdd-l6-l7-supply = <&vreg_bob2>; > > + vdd-l8-l9-supply = <&vreg_bob1>; > > + vdd-l12-supply = <&vreg_s5j_1p2>; > > + vdd-l15-supply = <&vreg_s4c_1p8>; > > + vdd-l17-supply = <&vreg_bob2>; > > + > > + vreg_bob1: bob1 { > > + regulator-name = "vreg_bob1"; > > + regulator-min-microvolt = <3008000>; > > + regulator-max-microvolt = <3960000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_bob2: bob2 { > > + regulator-name = "vreg_bob2"; > > + regulator-min-microvolt = <2504000>; > > + regulator-max-microvolt = <3008000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l2b_3p0: ldo2 { > > + regulator-name = "vreg_l2b_3p0"; > > + regulator-min-microvolt = <3072000>; > > + regulator-max-microvolt = <3072000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l4b_1p8: ldo4 { > > + regulator-name = "vreg_l4b_1p8"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l6b_1p8: ldo6 { > > + regulator-name = "vreg_l6b_1p8"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <2960000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l8b_3p0: ldo8 { > > + regulator-name = "vreg_l8b_3p0"; > > + regulator-min-microvolt = <3072000>; > > + regulator-max-microvolt = <3072000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l9b_2p9: ldo9 { > > + regulator-name = "vreg_l9b_2p9"; > > + regulator-min-microvolt = <2960000>; > > + regulator-max-microvolt = <2960000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l12b_1p2: ldo12 { > > + regulator-name = "vreg_l12b_1p2"; > > + regulator-min-microvolt = <1200000>; > > + regulator-max-microvolt = <1200000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l13b_3p0: ldo13 { > > + regulator-name = "vreg_l13b_3p0"; > > + regulator-min-microvolt = <3072000>; > > + regulator-max-microvolt = <3072000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l14b_3p0: ldo14 { > > + regulator-name = "vreg_l14b_3p0"; > > + regulator-min-microvolt = <3072000>; > > + regulator-max-microvolt = <3072000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l15b_1p8: ldo15 { > > + regulator-name = "vreg_l15b_1p8"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l17b_2p5: ldo17 { > > + regulator-name = "vreg_l17b_2p5"; > > + regulator-min-microvolt = <2504000>; > > + regulator-max-microvolt = <2504000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + }; > > + > > + regulators-1 { > > + compatible = "qcom,pm8550ve-rpmh-regulators"; > > + qcom,pmic-id = "c"; > > + vdd-l1-supply = <&vreg_s5j_1p2>; > > + vdd-l2-supply = <&vreg_s1f_0p7>; > > + vdd-l3-supply = <&vreg_s1f_0p7>; > > + > > + vreg_s4c_1p8: smps4 { > > + regulator-name = "vreg_s4c_1p8"; > > + regulator-min-microvolt = <1856000>; > > + regulator-max-microvolt = <2000000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l1c_1p2: ldo1 { > > + regulator-name = "vreg_l1c_1p2"; > > + regulator-min-microvolt = <1200000>; > > + regulator-max-microvolt = <1200000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l2c_0p8: ldo2 { > > + regulator-name = "vreg_l2c_0p8"; > > + regulator-min-microvolt = <880000>; > > + regulator-max-microvolt = <880000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l3c_0p9: ldo3 { > > + regulator-name = "vreg_l3c_0p9"; > > + regulator-min-microvolt = <920000>; > > + regulator-max-microvolt = <920000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + }; > > + > > + regulators-2 { > > + compatible = "qcom,pmc8380-rpmh-regulators"; > > + qcom,pmic-id = "d"; > > + vdd-l1-supply = <&vreg_s1f_0p7>; > > + vdd-l2-supply = <&vreg_s1f_0p7>; > > + vdd-l3-supply = <&vreg_s4c_1p8>; > > + vdd-s1-supply = <&vph_pwr>; > > + > > + vreg_l1d_0p8: ldo1 { > > + regulator-name = "vreg_l1d_0p8"; > > + regulator-min-microvolt = <880000>; > > + regulator-max-microvolt = <880000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l2d_0p9: ldo2 { > > + regulator-name = "vreg_l2d_0p9"; > > + regulator-min-microvolt = <912000>; > > + regulator-max-microvolt = <912000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l3d_1p8: ldo3 { > > + regulator-name = "vreg_l3d_1p8"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + }; > > + > > + regulators-3 { > > + compatible = "qcom,pmc8380-rpmh-regulators"; > > + qcom,pmic-id = "e"; > > + vdd-l2-supply = <&vreg_s1f_0p7>; > > + vdd-l3-supply = <&vreg_s5j_1p2>; > > + > > + vreg_l2e_0p8: ldo2 { > > + regulator-name = "vreg_l2e_0p8"; > > + regulator-min-microvolt = <880000>; > > + regulator-max-microvolt = <880000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l3e_1p2: ldo3 { > > + regulator-name = "vreg_l3e_1p2"; > > + regulator-min-microvolt = <1200000>; > > + regulator-max-microvolt = <1200000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + }; > > + > > + regulators-4 { > > + compatible = "qcom,pmc8380-rpmh-regulators"; > > + qcom,pmic-id = "f"; > > + vdd-l1-supply = <&vreg_s5j_1p2>; > > + vdd-l2-supply = <&vreg_s5j_1p2>; > > + vdd-l3-supply = <&vreg_s5j_1p2>; > > + vdd-s1-supply = <&vph_pwr>; > > + > > + vreg_s1f_0p7: smps1 { > > + regulator-name = "vreg_s1f_0p7"; > > + regulator-min-microvolt = <700000>; > > + regulator-max-microvolt = <1100000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + }; > > + > > + regulators-6 { > > + compatible = "qcom,pm8550ve-rpmh-regulators"; > > + qcom,pmic-id = "i"; > > + vdd-l1-supply = <&vreg_s4c_1p8>; > > + vdd-l2-supply = <&vreg_s5j_1p2>; > > + vdd-l3-supply = <&vreg_s1f_0p7>; > > + vdd-s1-supply = <&vph_pwr>; > > + vdd-s2-supply = <&vph_pwr>; > > + > > + vreg_s1i_0p9: smps1 { > > + regulator-name = "vreg_s1i_0p9"; > > + regulator-min-microvolt = <900000>; > > + regulator-max-microvolt = <920000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_s2i_1p0: smps2 { > > + regulator-name = "vreg_s2i_1p0"; > > + regulator-min-microvolt = <1000000>; > > + regulator-max-microvolt = <1100000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l1i_1p8: ldo1 { > > + regulator-name = "vreg_l1i_1p8"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l2i_1p2: ldo2 { > > + regulator-name = "vreg_l2i_1p2"; > > + regulator-min-microvolt = <1200000>; > > + regulator-max-microvolt = <1200000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l3i_0p8: ldo3 { > > + regulator-name = "vreg_l3i_0p8"; > > + regulator-min-microvolt = <880000>; > > + regulator-max-microvolt = <880000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + }; > > + > > + regulators-7 { > > + compatible = "qcom,pm8550ve-rpmh-regulators"; > > + qcom,pmic-id = "j"; > > + vdd-l1-supply = <&vreg_s1f_0p7>; > > + vdd-l2-supply = <&vreg_s5j_1p2>; > > + vdd-l3-supply = <&vreg_s1f_0p7>; > > + vdd-s5-supply = <&vph_pwr>; > > + > > + vreg_s5j_1p2: smps5 { > > + regulator-name = "vreg_s5j_1p2"; > > + regulator-min-microvolt = <1256000>; > > + regulator-max-microvolt = <1304000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l1j_0p9: ldo1 { > > + regulator-name = "vreg_l1j_0p9"; > > + regulator-min-microvolt = <912000>; > > + regulator-max-microvolt = <912000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l2j_1p2: ldo2 { > > + regulator-name = "vreg_l2j_1p2"; > > + regulator-min-microvolt = <1256000>; > > + regulator-max-microvolt = <1256000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_l3j_0p8: ldo3 { > > + regulator-name = "vreg_l3j_0p8"; > > + regulator-min-microvolt = <880000>; > > + regulator-max-microvolt = <880000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + }; > > + }; > > +}; > > + > > +&pcie4 { > > + perst-gpios = <&tlmm 146 GPIO_ACTIVE_LOW>; > > + wake-gpios = <&tlmm 148 GPIO_ACTIVE_LOW>; > > + > > + pinctrl-0 = <&pcie4_default>; > > + pinctrl-names = "default"; > > + > > + status = "okay"; > > +}; > > + > > +&pcie4_phy { > > + vdda-phy-supply = <&vreg_l3i_0p8>; > > + vdda-pll-supply = <&vreg_l3e_1p2>; > > + > > + status = "okay"; > > +}; > > + > > +&pcie6a { > > + perst-gpios = <&tlmm 152 GPIO_ACTIVE_LOW>; > > + wake-gpios = <&tlmm 154 GPIO_ACTIVE_LOW>; > > + > > + vddpe-3v3-supply = <&vreg_nvme>; > > + > > + pinctrl-0 = <&pcie6a_default>; > > + pinctrl-names = "default"; > > + > > + status = "okay"; > > +}; > > + > > +&pcie6a_phy { > > + vdda-phy-supply = <&vreg_l1d_0p8>; > > + vdda-pll-supply = <&vreg_l2j_1p2>; > > + > > + status = "okay"; > > +}; > > + > > +&qupv3_0 { > > + status = "okay"; > > +}; > > + > > +&qupv3_1 { > > + status = "okay"; > > +}; > > + > > +&qupv3_2 { > > + status = "okay"; > > +}; > > + > > +&remoteproc_adsp { > > + firmware-name = "qcom/x1e80100/dell/tributo/qcadsp8380.mbn", > > + "qcom/x1e80100/dell/tributo/adsp_dtbs.elf"; > > + > > + status = "okay"; > > +}; > > + > > +&remoteproc_cdsp { > > + firmware-name = "qcom/x1e80100/dell/tributo/qccdsp8380.mbn", > > + "qcom/x1e80100/dell/tributo/cdsp_dtbs.elf"; > > + > > + status = "okay"; > > +}; > > + > > +&gpu { > > + status = "okay"; > > + > > + zap-shader { > > + firmware-name = "qcom/x1e80100/dell/tributo/qcdxkmsuc8380.mbn"; > > + }; > > +}; > > + > > +&mdss { > > + status = "okay"; > > +}; > > + > > +&mdss_dp3 { > > + compatible = "qcom,x1e80100-dp"; > > + /delete-property/ #sound-dai-cells; > > + > > + status = "okay"; > > + > > + aux-bus { > > + panel { > > + /* 1920x1200 IPS panel is SHP1593, PNP09FF compatible */ > > + compatible = "edp-panel"; > > + power-supply = <&vreg_edp_3p3>; > > + > > + port { > > + edp_panel_in: endpoint { > > + remote-endpoint = <&mdss_dp3_out>; > > + }; > > + }; > > + }; > > + }; > > + > > + ports { > > + port@1 { > > + reg = <1>; > > + > > + mdss_dp3_out: endpoint { > > + data-lanes = <0 1 2 3>; > > + link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>; > > + > > + remote-endpoint = <&edp_panel_in>; > > + }; > > + }; > > + }; > > +}; > > + > > +&mdss_dp3_phy { > > + vdda-phy-supply = <&vreg_l3j_0p8>; > > + vdda-pll-supply = <&vreg_l2j_1p2>; > > + > > + status = "okay"; > > +}; > > + > > +&i2c0 { > > + clock-frequency = <400000>; > > + status = "okay"; > > + > > + keyboard@5 { > > + compatible = "hid-over-i2c"; > > + reg = <0x5>; > > + > > + hid-descr-addr = <0x20>; > > + interrupts-extended = <&tlmm 67 IRQ_TYPE_LEVEL_LOW>; > > + > > + pinctrl-0 = <&kybd_default>; > > + pinctrl-names = "default"; > > + > > + wakeup-source; > > + }; > > +}; > > + > > +&i2c3 { > > + clock-frequency = <400000>; > > + status = "disabled"; > > + /* PS8830 Retimer @0x8 */ > > + /* Unknown device @0x9 */ > > +}; > > + > > +&i2c5 { > > + clock-frequency = <100000>; > > + status = "disabled"; > > + /* Unknown device @0x3b */ > > +}; > > + > > +&i2c7 { > > + clock-frequency = <400000>; > > + status = "disabled"; > > + /* PS8830 Retimer @0x8 */ > > + /* Unknown device @0x9 */ > > +}; > > + > > +&i2c8 { > > + clock-frequency = <400000>; > > + > > + status = "okay"; > > + > > + touchscreen@0 { > > + compatible = "hid-over-i2c"; > > + reg = <0x0>; > > + > > + hid-descr-addr = <0x1>; > > + interrupts-extended = <&tlmm 51 IRQ_TYPE_LEVEL_LOW>; > > + > > + pinctrl-0 = <&ts0_default>; > > + pinctrl-names = "default"; > > + }; > > +}; > > + > > +&i2c9 { > > + clock-frequency = <400000>; > > + status = "disabled"; > > + /* USB3 retimer device @0x4f */ > > +}; > > + > > +&i2c17 { > > + clock-frequency = <400000>; > > + status = "okay"; > > + > > + touchpad@2c { > > + compatible = "hid-over-i2c"; > > + reg = <0x2c>; > > + > > + hid-descr-addr = <0x20>; > > + interrupts-extended = <&tlmm 3 IRQ_TYPE_LEVEL_LOW>; > > + > > + pinctrl-0 = <&tpad_default>; > > + pinctrl-names = "default"; > > + > > + wakeup-source; > > + }; > > +}; > > + > > +&smb2360_0_eusb2_repeater { > > + vdd18-supply = <&vreg_l3d_1p8>; > > + vdd3-supply = <&vreg_l2b_3p0>; > > +}; > > + > > +&smb2360_1_eusb2_repeater { > > + vdd18-supply = <&vreg_l3d_1p8>; > > + vdd3-supply = <&vreg_l14b_3p0>; > > +}; > > + > > +&tlmm { > > + gpio-reserved-ranges = <44 4>, /* SPI11 (TPM) */ > > + <76 4>, /* SPI19 (TZ Protected) */ > > + <238 1>; /* UFS Reset */ > > + > > + edp_reg_en: edp-reg-en-state { > > + pins = "gpio70"; > > + function = "gpio"; > > + drive-strength = <16>; > > + bias-disable; > > + }; > > + > > + kybd_default: kybd-default-state { > > + pins = "gpio67"; > > + function = "gpio"; > > + bias-pull-up; > > + }; > > + > > + nvme_reg_en: nvme-reg-en-state { > > + pins = "gpio18"; > > + function = "gpio"; > > + drive-strength = <2>; > > + bias-disable; > > + }; > > + > > + tpad_default: tpad-default-state { > > + disable-pins { > > + pins = "gpio38"; > > + function = "gpio"; > > + output-high; > > + }; > > + > > + int-n-pins { > > + pins = "gpio3"; > > + function = "gpio"; > > + bias-pull-up; > > + }; > > + > > + reset-n-pins { > > + pins = "gpio52"; > > + function = "gpio"; > > + bias-disable; > > + }; > > + }; > > + > > + ts0_default: ts0-default-state { > > + disable-pins { > > + pins = "gpio75"; > > + function = "gpio"; > > + output-high; > > + }; > > + > > + int-n-pins { > > + pins = "gpio51"; > > + function = "gpio"; > > + bias-pull-up; > > + }; > > + > > + reset-n-pins { > > + /* Technically should be High-Z input */ > > + pins = "gpio48"; > > + function = "gpio"; > > + output-low; > > + drive-strength = <2>; > > + }; > > + }; > > + > > + hall_int_n_default: hall-int-n-state { > > + pins = "gpio92"; > > + function = "gpio"; > > + > > + bias-disable; > > + }; > > + > > + pcie4_default: pcie4-default-state { > > + clkreq-n-pins { > > + pins = "gpio147"; > > + function = "pcie4_clk"; > > + drive-strength = <2>; > > + bias-pull-up; > > + }; > > + > > + perst-n-pins { > > + pins = "gpio146"; > > + function = "gpio"; > > + drive-strength = <2>; > > + bias-disable; > > + }; > > + > > + wake-n-pins { > > + pins = "gpio148"; > > + function = "gpio"; > > + drive-strength = <2>; > > + bias-pull-up; > > + }; > > + }; > > + > > + pcie6a_default: pcie6a-default-state { > > + clkreq-n-pins { > > + pins = "gpio153"; > > + function = "pcie6a_clk"; > > + drive-strength = <2>; > > + bias-pull-up; > > + }; > > + > > + perst-n-pins { > > + pins = "gpio152"; > > + function = "gpio"; > > + drive-strength = <2>; > > + bias-disable; > > + }; > > + > > + wake-n-pins { > > + pins = "gpio154"; > > + function = "gpio"; > > + drive-strength = <2>; > > + bias-pull-up; > > + }; > > + }; > > + > > + cam_indicator_en: cam-indicator-en-state { > > + pins = "gpio110"; > > + function = "gpio"; > > + drive-strength = <2>; > > + bias-disable; > > + }; > > +}; > > + > > +&uart21 { > > + compatible = "qcom,geni-debug-uart"; > > + status = "okay"; > > +}; > > + > > +&usb_1_ss0_hsphy { > > + vdd-supply = <&vreg_l3j_0p8>; > > + vdda12-supply = <&vreg_l2j_1p2>; > > + > > + phys = <&smb2360_0_eusb2_repeater>; > > + > > + status = "okay"; > > +}; > > + > > +&usb_1_ss0_qmpphy { > > + vdda-phy-supply = <&vreg_l3e_1p2>; > > + vdda-pll-supply = <&vreg_l1j_0p9>; > > + > > + status = "okay"; > > +}; > > + > > +&usb_1_ss0 { > > + status = "okay"; > > +}; > > + > > +&usb_1_ss0_dwc3 { > > + dr_mode = "host"; > > +}; > > + > > +&usb_1_ss0_dwc3_hs { > > + remote-endpoint = <&pmic_glink_ss0_hs_in>; > > +}; > > + > > +&usb_1_ss0_qmpphy_out { > > + remote-endpoint = <&pmic_glink_ss0_ss_in>; > > +}; > > + > > +&usb_1_ss1_hsphy { > > + vdd-supply = <&vreg_l3j_0p8>; > > + vdda12-supply = <&vreg_l2j_1p2>; > > + > > + phys = <&smb2360_1_eusb2_repeater>; > > + > > + status = "okay"; > > +}; > > + > > +&usb_1_ss1_qmpphy { > > + vdda-phy-supply = <&vreg_l3e_1p2>; > > + vdda-pll-supply = <&vreg_l2d_0p9>; > > + > > + status = "okay"; > > +}; > > + > > +&usb_1_ss1 { > > + status = "okay"; > > +}; > > + > > +&usb_1_ss1_dwc3 { > > + dr_mode = "host"; > > +}; > > + > > +&usb_1_ss1_dwc3_hs { > > + remote-endpoint = <&pmic_glink_ss1_hs_in>; > > +}; > > + > > +&usb_1_ss1_qmpphy_out { > > + remote-endpoint = <&pmic_glink_ss1_ss_in>; > > +}; > > -- > > 2.43.0 > > > >