On Wed, 18 Sept 2024 at 10:23, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 17/09/2024 23:29, Erez wrote: > >>> > >>> I install dt-schema_2023.11-3_all.deb > >>> with Debian trixie > >>> I get: > >>> > >>> l > >>> SCHEMA Documentation/devicetree/bindings/processed-schema.json > >>> Traceback (most recent call last): > >>> File "/usr/bin/dt-mk-schema", line 8, in <module> > >>> sys.exit(main()) > >>> ^^^^^^ > >>> File "/usr/lib/python3/dist-packages/dtschema/mk_schema.py", line 28, in main > >>> schemas = dtschema.DTValidator(args.schemas).schemas > >>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > >>> File "/usr/lib/python3/dist-packages/dtschema/validator.py", line > >>> 363, in __init__ > >>> self.make_property_type_cache() > >>> File "/usr/lib/python3/dist-packages/dtschema/validator.py", line > >>> 420, in make_property_type_cache > >>> self.props, self.pat_props = get_prop_types(self.schemas) > >>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > >>> File "/usr/lib/python3/dist-packages/dtschema/validator.py", line > >>> 187, in get_prop_types > >>> del props[r'^[a-z][a-z0-9\-]*$'] > >>> ~~~~~^^^^^^^^^^^^^^^^^^^^^^^ > >>> KeyError: '^[a-z][a-z0-9\\-]*$' > >>> make[2]: *** [Documentation/devicetree/bindings/Makefile:64: > >>> Documentation/devicetree/bindings/processed-schema.json] Error 1 > >>> make[2]: *** Deleting file > >>> 'Documentation/devicetree/bindings/processed-schema.json' > >>> make[1]: *** [/home/builder/kernel/Makefile:1435: dt_binding_schemas] Error 2 > >> > >> Have you considered that this might be because of the invalid types you > >> used? > > > > I remove the types. > > Anyway, scripts should report on errors, not crash. > > This is the purpose of syntax scripts, to help us, developers find out errors. > > Yeah, things can be improved. Help in that is always welcomed. > > The package you installed is very old (almost a year old!). I suggest Debian tend to be old and stable (althguh this packages comes from sid). > using pip or pipx (or virtualenv or whatever Python setup you have). I'll try. Though I am not a python developer. I usually do not use pip. I did see a version checking: $ make dt_binding_check sort: -:2: disorder: 2022.08.2 ERROR: dtschema minimum version is v2023.9 Thanks Erez > > Best regards, > Krzysztof >
