On 17/09/2024 19:24, Erez wrote: >>>>>> >>>>>> It does not look like you tested the bindings, at least after quick >>>>>> look. Please run `make dt_binding_check` (see >>>>> >>>>> I run "make dt_binding_check" on kernel 6.6. >>>> >>>> Yeah, we are no on kernel 6.6. You can run it also on kernel v4.1 - >>>> still does not matter. >>>> >>>> Don't develop on ancient code because then you ask us to review same >>>> broken stuff we already fixed. >>> >>> I test with Beaglebone black for testing, it is difficult to run the >>> last vanille version. >>> I did backport the spi-nor driver. >>> As for "make dt_binding_check" on last kernel, it need to upgrade the tools, >>> and I did not think it could change that much. >>> >> >> Well, it is possible to build kernel on small embedded board, but that's >> quite cumbersone, slow and inefficient, considering that it's just >> easier to cross compile. But anyway, binding check does not even need >> cross compilation. >> >> Sorry, the code is obviously wrong, there is no such thing as u32, so >> you did not test it. I provided link which explains how to test it. You >> must do it on latest mainline kernel. Just like you must develop and >> generate patches on latest mainline kernel, because this is where we >> apply the patches. We do not apply them to v6.6. > > The patches are based on the lastest mainline kernel. > I do not understand why you think otherwise. Because you wrote: "I run "make dt_binding_check" on kernel 6.6." The command is either part of build process or final check process (static analyzers etc). If you say you did this on v6.6, you got such response. Best regards, Krzysztof
