On 10/08/2024 01:38, Tristram.Ha@xxxxxxxxxxxxx wrote: > From: Tristram Ha <tristram.ha@xxxxxxxxxxxxx> > > The SGMII module of KSZ9477 switch can be setup in 3 ways: 0 for direct > connect, 1 for 1000BaseT SFP, and 2 for 10/100/1000 SFP. Binding should say it, not commit msg. But aren't you duplicating something like phy-connection-type? > > SFP is typically used so the default is 1. The driver can detect > 10/100/1000 SFP and change the mode to 2. For direct connect this mode > has to be explicitly set to 0 as driver cannot detect that > configuration. > > Signed-off-by: Tristram Ha <tristram.ha@xxxxxxxxxxxxx> > --- > .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > index 52acc15ebcbf..b4a9746556bf 100644 > --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > @@ -71,6 +71,13 @@ properties: > enum: [2000, 4000, 8000, 12000, 16000, 20000, 24000, 28000] > default: 8000 > > + microchip,sgmii-mode: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + SGMII mode to use for the SGMII port > + enum: [0, 1, 2] > + default: 1 > + > interrupts: > maxItems: 1 > > @@ -137,6 +144,7 @@ examples: > compatible = "microchip,ksz9477"; > reg = <0>; > reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>; > + sgmii-mode = <1>; It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof
