On Fri, 09 Aug 2024 16:38:37 -0700, Tristram.Ha@xxxxxxxxxxxxx wrote: > From: Tristram Ha <tristram.ha@xxxxxxxxxxxxx> > > The SGMII module of KSZ9477 switch can be setup in 3 ways: 0 for direct > connect, 1 for 1000BaseT SFP, and 2 for 10/100/1000 SFP. > > SFP is typically used so the default is 1. The driver can detect > 10/100/1000 SFP and change the mode to 2. For direct connect this mode > has to be explicitly set to 0 as driver cannot detect that > configuration. > > Signed-off-by: Tristram Ha <tristram.ha@xxxxxxxxxxxxx> > --- > .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/dsa/microchip,ksz.example.dtb: switch@0: Unevaluated properties are not allowed ('sgmii-mode' was unexpected) from schema $id: http://devicetree.org/schemas/net/dsa/microchip,ksz.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240809233840.59953-2-Tristram.Ha@xxxxxxxxxxxxx The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.