> On 10/08/2024 01:38, Tristram.Ha@xxxxxxxxxxxxx wrote: > > From: Tristram Ha <tristram.ha@xxxxxxxxxxxxx> > > > > The SGMII module of KSZ9477 switch can be setup in 3 ways: 0 for direct > > connect, 1 for 1000BaseT SFP, and 2 for 10/100/1000 SFP. > > Binding should say it, not commit msg. But aren't you duplicating > something like phy-connection-type? The sgmii-mode parameter is just used internally. I am not sure using phy-connection-type or phy-mode is appropriate. > > @@ -137,6 +144,7 @@ examples: > > compatible = "microchip,ksz9477"; > > reg = <0>; > > reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>; > > + sgmii-mode = <1>; > > It does not look like you tested the bindings, at least after quick > look. Please run `make dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Maybe you need to update your dtschema and yamllint. Sorry, I missed the example part.
