Hi Nishanth, On Jun 18, 2024 at 12:31:21 -0500, Nishanth Menon wrote: > Introduce a GPIO mux mode macro for easier readability. All K3 devices > use mux mode 7 to switch to GPIO mux. > > Signed-off-by: Nishanth Menon <nm@xxxxxx> > --- > arch/arm64/boot/dts/ti/k3-pinctrl.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-pinctrl.h b/arch/arm64/boot/dts/ti/k3-pinctrl.h > index 4cd2df467d0b..b1a0415e6611 100644 > --- a/arch/arm64/boot/dts/ti/k3-pinctrl.h > +++ b/arch/arm64/boot/dts/ti/k3-pinctrl.h > @@ -38,6 +38,8 @@ > #define PIN_DEBOUNCE_CONF5 (5 << DEBOUNCE_SHIFT) > #define PIN_DEBOUNCE_CONF6 (6 << DEBOUNCE_SHIFT) > > +#define PIN_GPIO_MUX_MODE (7) > + While I do agree that this is a standard thing, don't you think that updating it everywhere else (k3 DTs) makes sense? Having the number 7 in some places and others having PIN_GPIO_MUX_MODE will give rise to confusion I feel. -- Best regards, Dhruva Gole <d-gole@xxxxxx>
