On Fri, Apr 12, 2024 at 09:00:53AM +0000, Jason-JH Lin (林睿祥) wrote: > On Tue, 2024-04-09 at 18:52 +0100, Conor Dooley wrote: > > On Sat, Apr 06, 2024 at 04:15:51PM +0000, Jason-JH Lin (林睿祥) wrote: > > > On Fri, 2024-04-05 at 17:13 +0100, Conor Dooley wrote: > > > > On Fri, Apr 05, 2024 at 02:33:14PM +0000, Jason-JH Lin (林睿祥) > > > > wrote: > > > > > On Thu, 2024-04-04 at 15:52 +0100, Conor Dooley wrote: > > > > > > On Thu, Apr 04, 2024 at 04:31:06AM +0000, Jason-JH Lin (林睿祥) > > > > > > wrote: > > > > > > > Hi Conor, > > > > > > > > > > > > > > Thanks for the reviews. > > > > > > > > > > > > > > On Wed, 2024-04-03 at 16:46 +0100, Conor Dooley wrote: > > > > > > > > On Wed, Apr 03, 2024 at 06:25:54PM +0800, Shawn Sung > > > > > > > > wrote: > > > > > > > > > From: "Jason-JH.Lin" <jason-jh.lin@xxxxxxxxxxxx> > > > > > > > > > + mediatek,gce-events: > > > > > > > > > + description: > > > > > > > > > + The event id which is mapping to the specific > > > > > > > > > hardware > > > > > > > > > event > > > > > > > > > signal > > > > > > > > > + to gce. The event id is defined in the gce > > > > > > > > > header > > > > > > > > > + include/dt-bindings/gce/<chip>-gce.h of each > > > > > > > > > chips. > > > > > > > > > > > > > > > > Missing any info here about when this should be used, > > > > > > > > hint - > > > > > > > > you > > > > > > > > have > > > > > > > > it > > > > > > > > in the commit message. > > > > > > > > > > > > > > > > > + $ref: /schemas/types.yaml#/definitions/uint32- > > > > > > > > > arrayi > > > > > > > > > > > > > > > > Why is the ID used by the CMDQ service not fixed for each > > > > > > > > SoC? > > Did I misunderstand the ID here? > I thought we were talking about event IDs, but it looks like we are > talking about mbox IDs. We were talking about the event IDs FWIW. Just send a new version with some actual explanations added (as we discussed earlier on this thread) and we should be good here I think. Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature
