On Thu, Apr 04, 2024 at 04:31:06AM +0000, Jason-JH Lin (林睿祥) wrote: > Hi Conor, > > Thanks for the reviews. > > On Wed, 2024-04-03 at 16:46 +0100, Conor Dooley wrote: > > On Wed, Apr 03, 2024 at 06:25:54PM +0800, Shawn Sung wrote: > > > From: "Jason-JH.Lin" <jason-jh.lin@xxxxxxxxxxxx> > > > > > > Add mboxes to define a GCE loopping thread as a secure irq handler. > > > This property is only required if CMDQ secure driver is supported. > > > > > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx> > > > Signed-off-by: Hsiao Chien Sung <shawn.sung@xxxxxxxxxxxx> > > > --- > > > .../bindings/mailbox/mediatek,gce-mailbox.yaml | 10 > > > ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/mailbox/mediatek,gce- > > > mailbox.yaml > > > b/Documentation/devicetree/bindings/mailbox/mediatek,gce- > > > mailbox.yaml > > > index cef9d76013985..c0d80cc770899 100644 > > > --- a/Documentation/devicetree/bindings/mailbox/mediatek,gce- > > > mailbox.yaml > > > +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce- > > > mailbox.yaml > > > @@ -49,6 +49,16 @@ properties: > > > items: > > > - const: gce > > > > > > + mediatek,gce-events: > > > + description: > > > + The event id which is mapping to the specific hardware event > > > signal > > > + to gce. The event id is defined in the gce header > > > + include/dt-bindings/gce/<chip>-gce.h of each chips. > > > > Missing any info here about when this should be used, hint - you have > > it > > in the commit message. > > > > > + $ref: /schemas/types.yaml#/definitions/uint32-arrayi > > > > Why is the ID used by the CMDQ service not fixed for each SoC? > > > I forgot to sync with Shawn about this: > https://lore.kernel.org/all/20240124011459.12204-1-jason- > jh.lin@xxxxxxxxxxxx > > I'll fix it at the next version. When I say "fixed" I don't mean "this is wrong, please fix it", I mean "why is the value not static for a particular SoC". This needs to be explained in the patch (and the description for the event here needs to explain what the gce-mailbox is reserving an event for). Thanks, Conor.
Attachment:
signature.asc
Description: PGP signature
