Hi Florian, On Tue, Apr 02, 2024 at 01:18:35PM -0700, Florian Fainelli wrote: > On 4/2/24 13:08, Laurent Pinchart wrote: > > On Tue, Apr 02, 2024 at 09:52:06PM +0200, Stefan Wahren wrote: > >> Am 02.04.24 um 10:58 schrieb Ivan T. Ivanov: > >>> On 2024-03-28 01:37, Laurent Pinchart wrote: > >>>> On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: > >>>>> Hi, > >>>>> > >>>>> [add Peter and Ivan] > >>>>> > >>>>> Am 26.03.24 um 20:58 schrieb Laurent Pinchart: > >>>>>> Hello, > >>>>>> > >>>>>> This small series includes a few drive-by fixes for DT validation > >>>>>> errors. > >>>>>> > >>>>>> The first patch has been posted previously in v1 ([1], and now addresses > >>>>>> a small review comment. I think it's good to go. > >>>>>> > >>>>>> The next two patches address the same issue as "[PATCH 1/2] dt-bindings: > >>>>>> arm: bcm: raspberrypi,bcm2835-firmware: Add missing properties" ([2]), > >>>>>> but this time with a (hopefully) correct approach. Patch 2/3 starts by > >>>>>> fixing the raspberrypi-bcm2835-firmware driver, removing the need for DT > >>>>>> properties that are specified in bcm2835-rpi.dtsi but not documented in > >>>>>> the corresponding bindings. Patch 3/3 can then drop those properties, > >>>>>> getting rid of the warnings. > >>>>> > >>>>> since this series drops properties from the device tree, does anyone > >>>>> have the chance to test it with a recent U-Boot? > >>>> > >>>> I don't have U-Boot running with my RPi, so I would appreciate if > >>>> someone could help :-) > >>> > >>> Sorry for taking me so long to verify this. > >>> > >>> I think on RPi U-Boot side we are fine. API used when accessing Mbox > >>> device do not follow DM model and do not use DMA, but just access > >>> device directly using this nice macros phys_to_bus/bus_to_phys. > >>> > >>> I build new DTB files with this patch included and U-Boot build > >>> from the latest sources. No obvious issues on RPi3 and RPi4. > >>> Devices boot fine. > > > > Thank you for testing Ivan. > > > >> Thanks you, Laurent and Ivan > >> > >> Reviewed-by: Stefan Wahren <wahrenst@xxxxxxx> > > > > Stefan, I'm quite unfamiliar with the Raspberry Pi upstreaming process > > (despite having sent patches for ages :-)), do I understand correctly > > that this patch will go through your tree, or do I need to work with > > someone else to get it merged upstream ? > > I will be taking those via the Broadcom SoC tree. Thank you. If there's a chance to include patches 05/10, 07/10, 08/10 and 09/10 from [1] at the same time, that would be great :-) [1] https://lore.kernel.org/linux-media/20240402000424.4650-1-laurent.pinchart@xxxxxxxxxxxxxxxx -- Regards, Laurent Pinchart