On 01/04/2024 05:36, Qingfang Deng wrote: > Hi Krzysztof, > > On Sun, Mar 31, 2024 at 1:42 AM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> On 29/03/2024 02:51, Qingfang Deng wrote: >>> Add YAML devicetree bindings for Siflower Quad SPI controller. >> >> Describe the hardware. What is this Siflower? > > It's a new RISC-V SoC which hasn't been upstreamed yet. > >>> +properties: >>> + compatible: >>> + const: siflower,qspi >> >> Except that this was not tested, aren't you adding it for some SoC? If >> so, then you miss here SoC part. > > I should add the "siflower" prefix to > Documentation/devicetree/bindings/vendor-prefixes.yaml, right? Isn't it already there? Then obvious you must, but that was not the point. Please read writing-bindings document. Compatibles should be SoC specific, not generic. "qspi" is generic. Best regards, Krzysztof