On 29/03/2024 02:51, Qingfang Deng wrote: > From: Qingfang Deng <qingfang.deng@xxxxxxxxxxxxxxx> > > Add YAML devicetree bindings for Siflower Quad SPI controller. Describe the hardware. What is this Siflower? > > Signed-off-by: Qingfang Deng <qingfang.deng@xxxxxxxxxxxxxxx> > --- > .../bindings/spi/siflower,qspi.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/siflower,qspi.yaml > > diff --git a/Documentation/devicetree/bindings/spi/siflower,qspi.yaml b/Documentation/devicetree/bindings/spi/siflower,qspi.yaml > new file mode 100644 > index 000000000000..c2dbe82affc2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/siflower,qspi.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/siflower,qspi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Siflower Quad Serial Peripheral Interface (QSPI) > + > +maintainers: > + - Qingfang Deng <qingfang.deng@xxxxxxxxxxxxxxx> > + > +allOf: > + - $ref: spi-controller.yaml# > + > +properties: > + compatible: > + const: siflower,qspi Except that this was not tested, aren't you adding it for some SoC? If so, then you miss here SoC part. Best regards, Krzysztof
