Hi Krzysztof, On Sun, Mar 31, 2024 at 1:42 AM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 29/03/2024 02:51, Qingfang Deng wrote: > > Add YAML devicetree bindings for Siflower Quad SPI controller. > > Describe the hardware. What is this Siflower? It's a new RISC-V SoC which hasn't been upstreamed yet. > > +properties: > > + compatible: > > + const: siflower,qspi > > Except that this was not tested, aren't you adding it for some SoC? If > so, then you miss here SoC part. I should add the "siflower" prefix to Documentation/devicetree/bindings/vendor-prefixes.yaml, right? Regards, Qingfang
