Re: [RESEND PATCH v2 1/4] arm64: dts: ti: k3-j7200-common-proc-board: Modify Pinmux for wkup_uart0 and mcu_uart0

[Bhavya Kapoor <b-kapoor@xxxxxx>]

On 14/02/24 12:58 pm, Vignesh Raghavendra wrote:
> On 12/02/24 16:14, Bhavya Kapoor wrote:
> > WKUP_PADCONFIG registers for wkup_uart0 and mcu_uart0 lies
> > under wkup_pmx2 for J7200. Thus, modify pinmux for both
> > of them.
> >
> > Signed-off-by: Bhavya Kapoor <b-kapoor@xxxxxx>
> > ---
>
> This warrants a Fixes: tag. Can you provide one here? I can fix it up
> when merging.
Yes , i agree to that. I will send a v3 with the required changes
> >   .../boot/dts/ti/k3-j7200-common-proc-board.dts  | 17 +++++++++--------
> >   1 file changed, 9 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> > index 1d8bddcae90e..160580a0584a 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> > @@ -119,24 +119,25 @@ transceiver3: can-phy3 {
> >   };
> >   
> >   &wkup_pmx0 {
> > +};
> > +
> > +&wkup_pmx2 {
> >   	mcu_uart0_pins_default: mcu-uart0-default-pins {
> >   		pinctrl-single,pins = <
> > -			J721E_WKUP_IOPAD(0xf4, PIN_INPUT, 0) /* (D20) MCU_UART0_RXD */
> > -			J721E_WKUP_IOPAD(0xf0, PIN_OUTPUT, 0) /* (D19) MCU_UART0_TXD */
> > -			J721E_WKUP_IOPAD(0xf8, PIN_INPUT, 0) /* (E20) MCU_UART0_CTSn */
> > -			J721E_WKUP_IOPAD(0xfc, PIN_OUTPUT, 0) /* (E21) MCU_UART0_RTSn */
> > +			J721E_WKUP_IOPAD(0x90, PIN_INPUT, 0) /* (E20) MCU_UART0_CTSn */
> > +			J721E_WKUP_IOPAD(0x94, PIN_OUTPUT, 0) /* (E21) MCU_UART0_RTSn */
> > +			J721E_WKUP_IOPAD(0x8c, PIN_INPUT, 0) /* (D20) MCU_UART0_RXD */
> > +			J721E_WKUP_IOPAD(0x88, PIN_OUTPUT, 0) /* (D19) MCU_UART0_TXD */
> >   		>;
> >   	};
> >   
> >   	wkup_uart0_pins_default: wkup-uart0-default-pins {
> >   		pinctrl-single,pins = <
> > -			J721E_WKUP_IOPAD(0xb0, PIN_INPUT, 0) /* (B14) WKUP_UART0_RXD */
> > -			J721E_WKUP_IOPAD(0xb4, PIN_OUTPUT, 0) /* (A14) WKUP_UART0_TXD */
> > +			J721E_WKUP_IOPAD(0x48, PIN_INPUT, 0) /* (B14) WKUP_UART0_RXD */
> > +			J721E_WKUP_IOPAD(0x4c, PIN_OUTPUT, 0) /* (A14) WKUP_UART0_TXD */
> >   		>;
> >   	};
> > -};
> >   
> > -&wkup_pmx2 {
> >   	mcu_cpsw_pins_default: mcu-cpsw-default-pins {
> >   		pinctrl-single,pins = <
> >   			J721E_WKUP_IOPAD(0x0000, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */