On Wed, Oct 11, 2023 at 04:05:47PM +0200, Arnd Bergmann wrote:
> On Wed, Oct 11, 2023, at 15:59, Sudeep Holla wrote:
> > On Wed, Oct 11, 2023 at 03:14:08PM +0200, Arnd Bergmann wrote:
> >> From: Arnd Bergmann <arnd@xxxxxxxx>
> >>
> >> This function is now called from a cpufreq driver, but that breaks the
> >> build when the caller is in a loadable module, because of a missing
> >> export:
> >>
> >> ERROR: modpost: "of_find_next_cache_node" [drivers/cpufreq/qcom-cpufreq-nvmem.ko] undefined!
> >>
> >> Export this as a GPL-only symbol, like the other related functions in
> >> this file.
> >>
> >> Fixes: 7683a63c08ff5 ("cpufreq: qcom-nvmem: create L2 cache device")
> >> Fixes: a3e31b4588443 ("of: Move definition of of_find_next_cache_node into common code.")
> >
> > I am bit confused as I see commit a3e31b4588443 didn't drop the export.
> > So how is this change fixing that commit ?
>
> My mistake, I was looking for the commit that initially introduced
> the function, but didn't notice that this just moved it from powerpc.
>
> I could have used "Fixes: e523f723d69cd ("powerpc: Add
> of_find_next_cache_node()")", but it's probably best to just
> leave that line out entirely.
>
Yes I was thinking to drop it as it is quite old commit(both a3e31b4588443 and
e523f723d69cd) and I don't see any point in merging this to all the concerned
stable trees as they must not have this new user.
That said it is not a complex change, so I am fine either way, just thought
of raising it in case it was not intentional.
--
Regards,
Sudeep
