On Wed, 11 Oct 2023 at 16:14, Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> This function is now called from a cpufreq driver, but that breaks the
> build when the caller is in a loadable module, because of a missing
> export:
>
> ERROR: modpost: "of_find_next_cache_node" [drivers/cpufreq/qcom-cpufreq-nvmem.ko] undefined!
>
> Export this as a GPL-only symbol, like the other related functions in
> this file.
>
> Fixes: 7683a63c08ff5 ("cpufreq: qcom-nvmem: create L2 cache device")
> Fixes: a3e31b4588443 ("of: Move definition of of_find_next_cache_node into common code.")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Thanks for the patch. I've also sent a similar patch at [1]. Now we
are discussing with Rob if the overall idea of the L2 cache device is
correct or not.
[1] https://lore.kernel.org/linux-arm-msm/CAA8EJppCO-q=swYOH+O2fOdUDbNzd1yz9ZoTEBswV7RmvFJifA@xxxxxxxxxxxxxx/T/#t
--
With best wishes
Dmitry
