On Wed, Oct 11, 2023 at 03:14:08PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@xxxxxxxx> > > This function is now called from a cpufreq driver, but that breaks the > build when the caller is in a loadable module, because of a missing > export: > > ERROR: modpost: "of_find_next_cache_node" [drivers/cpufreq/qcom-cpufreq-nvmem.ko] undefined! > > Export this as a GPL-only symbol, like the other related functions in > this file. > > Fixes: 7683a63c08ff5 ("cpufreq: qcom-nvmem: create L2 cache device") > Fixes: a3e31b4588443 ("of: Move definition of of_find_next_cache_node into common code.") I am bit confused as I see commit a3e31b4588443 didn't drop the export. So how is this change fixing that commit ? -- Regards, Sudeep