On Thu, Aug 24, 2023 at 02:53:13PM +0200, Martin Zaťovič wrote: > On Thu, Aug 24, 2023 at 01:40:35PM +0200, Greg KH wrote: > > On Thu, Aug 24, 2023 at 01:10:13PM +0200, Martin Zaťovič wrote: ... > > > +static inline void wiegand_controller_put(void *ptr) > > > > Why is this a void *? It should be "struct wiegand_controller *" > > It is a void* because it is being passed to devm_add_action_or_reset() > and this function only accepts a pointer to a function that accepts a void* > parameter. I am not sure if there is a way around it. I just replied with a deeper review with the answer to this. > > Please never use void * if at all possible. Correct. We better to have a type checking when possible. Esp. for the exported functions. -- With Best Regards, Andy Shevchenko
