Hello, I have fixed all the pointed out issues and I present the next version of Wiegand bus driver and Wiegand GPIO bitbanged controller. The most noticable change is the change of the input data format, which is now ASCII hex string. Please let me know, if you see any issues. I have also included a brief information about Wiegand in the commit message of the commit adding the bus driver, since there is no official datasheet that I could link. CHANGELOG: wiegand.c - kernel symbols are now part of WIEGAND namespace - added includes for conatiner_of.h and types.h - made IDA static - removed redundant null checks and error messages - added overflow check for memory allocation size - used devm_add_action_or_reset() for controller allocation - fixed comments according to kernel doc validator - avoided dereferencing fwnode in struct device by using device_set_node() - fixed fwnode format specifier - removed the overly complicated system for getting timings and replaced it with a clear and easily understandable one - unified the goto label names - removed static keyword from struct bus_type - used bitmap_parse_user() function to parse the user data, which also means that the input format has changed to ASCII hex string - removed input length checks as they are not valid anymore using the new input format wiegand.h - removed unnecesary mod_devicetable.h include and added container_of.h and types.h includes - added fs.h header for struct file_operations - removed underscores in some variables names within macros wiegand-gpio.c - fixed some error codes - used fsleep() in the wiegand_gpio_send_bit() function - edited the loop in wiegand_gpio_write_by_bits() so that it doesnt check for the last bit in each iteration - used the devm_gpiod_get_array() for acquiring the two gpio lines - imported WIEGAND namespace wiegand-gpio.yaml - dropped devicetree bindings Martin Zaťovič (4): dt-bindings: wiegand: add Wiegand controller common properties wiegand: add Wiegand bus driver dt-bindings: wiegand: add GPIO bitbanged Wiegand controller wiegand: add Wiegand GPIO bitbanged controller driver .../ABI/testing/sysfs-driver-wiegand-gpio | 9 + .../bindings/wiegand/wiegand-controller.yaml | 39 ++ .../bindings/wiegand/wiegand-gpio.yaml | 46 ++ MAINTAINERS | 14 + drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/wiegand/Kconfig | 36 ++ drivers/wiegand/Makefile | 2 + drivers/wiegand/wiegand-gpio.c | 192 ++++++ drivers/wiegand/wiegand.c | 590 ++++++++++++++++++ include/linux/wiegand.h | 148 +++++ 11 files changed, 1079 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-driver-wiegand-gpio create mode 100644 Documentation/devicetree/bindings/wiegand/wiegand-controller.yaml create mode 100644 Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml create mode 100644 drivers/wiegand/Kconfig create mode 100644 drivers/wiegand/Makefile create mode 100644 drivers/wiegand/wiegand-gpio.c create mode 100644 drivers/wiegand/wiegand.c create mode 100644 include/linux/wiegand.h -- 2.40.1
