On Thu, Aug 24, 2023 at 01:10:13PM +0200, Martin Zaťovič wrote:
> +static inline void wiegand_controller_put(void *ptr)
Why is this a void *? It should be "struct wiegand_controller *"
Please never use void * if at all possible.
> +static inline void wiegand_unregister_driver(struct wiegand_driver *wdrv)
> +{
> + if (wdrv)
How could this ever be true?
> + driver_unregister(&wdrv->driver);
> +}
> +
> +static inline struct wiegand_driver *to_wiegand_driver(struct device_driver *drv)
> +{
> + return drv ? container_of(drv, struct wiegand_driver, driver) : NULL;
How could drv be NULL?
And you should make this a const *, right?
thanks,
greg k-h
