Re: [PATCH v3 3/5] dt-bindings: clock: add Intel Agilex5 clock manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 8/2/23 02:14, Rabara, Niravkumar L wrote:


-----Original Message-----
From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
Sent: Wednesday, 2 August, 2023 3:02 PM
To: Rabara, Niravkumar L <niravkumar.l.rabara@xxxxxxxxx>
Cc: Ng, Adrian Ho Yin <adrian.ho.yin.ng@xxxxxxxxx>; andrew@xxxxxxx;
conor+dt@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; dinguyen@xxxxxxxxxx;
krzysztof.kozlowski+dt@xxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; linux-
kernel@xxxxxxxxxxxxxxx; Turquette, Mike <mturquette@xxxxxxxxxxxx>;
netdev@xxxxxxxxxxxxxxx; p.zabel@xxxxxxxxxxxxxx;
richardcochran@xxxxxxxxx; robh+dt@xxxxxxxxxx; sboyd@xxxxxxxxxx;
wen.ping.teh@xxxxxxxxx
Subject: Re: [PATCH v3 3/5] dt-bindings: clock: add Intel Agilex5 clock
manager

On Wed, Aug 02, 2023 at 10:58:42AM +0800, niravkumar.l.rabara@xxxxxxxxx
wrote:
From: Niravkumar L Rabara <niravkumar.l.rabara@xxxxxxxxx>

Add clock ID definitions for Intel Agilex5 SoCFPGA.
The registers in Agilex5 handling the clock is named as clock manager.

Signed-off-by: Teh Wen Ping <wen.ping.teh@xxxxxxxxx>
Reviewed-by: Dinh Nguyen <dinguyen@xxxxxxxxxx>
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@xxxxxxxxx>

Damn, I was too late - you already sent a v3 :/

However, there only seems to be a v3 of this one patch and it was sent in
reply to the v2 series? The normal thing to do is resend the entire series, not
just one patch, as a new thread. Not using a new thread may make it harder
to apply & will also bury the email in people's mailboxes that use things like
mutt. A single patch as a reply is also confusing, as the rest of the v3 looks like
it is missing!

Thanks,
Conor.

Sorry I made a mistake.
Should I send out entire series with PATCH v3 subject? Or should I wait for review comment on remaining patches and then send entire series with rework and  subject prefix PATCH v3?


No need to send out a V3. I've applied patches 1-3 and 5. Will give a little more time for the clk patch.

Dinh



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux