-------- 原始信息 -------- 主题: Re: [PATCH v1 0/2] Add ethernet nodes for StarFive JH7110 SoC From: Conor Dooley <conor@xxxxxxxxxx> 收件人: Guo Samin <samin.guo@xxxxxxxxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Albert Ou <aou@xxxxxxxxxxxxxxxxx>, Hal Feng <hal.feng@xxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx 日期: 2023/7/21 > > > On 21 July 2023 03:09:19 IST, Guo Samin <samin.guo@xxxxxxxxxxxxxxxx> wrote: >> >> >> -------- 原始信息 -------- >> 主题: Re: [PATCH v1 0/2] Add ethernet nodes for StarFive JH7110 SoC >> From: Conor Dooley <conor@xxxxxxxxxx> >> 收件人: Conor Dooley <conor@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Albert Ou <aou@xxxxxxxxxxxxxxxxx>, Hal Feng <hal.feng@xxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, Samin Guo <samin.guo@xxxxxxxxxxxxxxxx> >> 日期: 2023/7/21 >> >>> From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> >>> >>> On Fri, 14 Jul 2023 18:45:19 +0800, Samin Guo wrote: >>>> This series adds ethernet nodes for StarFive JH7110 RISC-V SoC, >>>> and has been tested on StarFive VisionFive-2 v1.2A and v1.3B SBC boards. >>>> >>>> The first patch adds ethernet nodes for jh7110 SoC, the second patch >>>> adds ethernet nodes for visionfive 2 SBCs. >>>> >>>> This series relies on xingyu's syscon patch[1]. >>>> For more information and support, you can visit RVspace wiki[2]. >>>> >>>> [...] >>> >>> Applied to riscv-dt-for-next, thanks! >>> >>> [1/2] riscv: dts: starfive: jh7110: Add ethernet device nodes >>> https://git.kernel.org/conor/c/1ff166c97972 >>> [2/2] riscv: dts: starfive: visionfive 2: Add configuration of gmac and phy >>> https://git.kernel.org/conor/c/b15a73c358d1 >>> >>> Thanks, >>> Conor. >> >> >> Hi Conor， >> >> Thank you so much！ >> >> There is a question about the configuration of phy that I would like to consult you. >> >> Latest on motorcomm PHY V5[1]: Follow Rob Herring's advice >> motorcomm,rx-xxx-driver-strength Changed to motorcomm,rx-xxx-drv-microamp . >> V5 has already received a reviewed-by from Andrew Lunn, and it should not change again. >> >> Should I submit another pacthes based on riscv-dt-for-next? > > Huh, dtbs_check passed for these patches, > I didn't realise changes to the motorcomm stuff > were a dep. for this. I'll take a look later. > Hi Conor, Thanks for taking the time to follow this. After discussing with HAL, I have prepared the code and considered adding the following patch to Motorcomm's patchsetes v6. (To fix some spelling errors in v5[1]) which will then send patches based on linux-next. What do you think? @Andrew @Conor [1] https://patchwork.kernel.org/project/netdevbpf/cover/20230720111509.21843-1-samin.guo@xxxxxxxxxxxxxxxx --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dts +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dts @@ -28,8 +28,8 @@ motorcomm,tx-clk-adj-enabled; motorcomm,tx-clk-100-inverted; motorcomm,tx-clk-1000-inverted; - motorcomm,rx-clk-driver-strength = <3970>; - motorcomm,rx-data-driver-strength = <2910>; + motorcomm,rx-clk-drv-microamp = <3970>; + motorcomm,rx-data-drv-microamp = <2910>; rx-internal-delay-ps = <1500>; tx-internal-delay-ps = <1500>; }; @@ -37,8 +37,8 @@ &phy1 { motorcomm,tx-clk-adj-enabled; motorcomm,tx-clk-100-inverted; - motorcomm,rx-clk-driver-strength = <3970>; - motorcomm,rx-data-driver-strength = <2910>; + motorcomm,rx-clk-drv-microamp = <3970>; + motorcomm,rx-data-drv-microamp = <2910>; rx-internal-delay-ps = <300>; tx-internal-delay-ps = <0>; }; Best regards, Samin >> >> [1] https://patchwork.kernel.org/project/netdevbpf/cover/20230720111509.21843-1-samin.guo@xxxxxxxxxxxxxxxx >> >> >> Best regards, >> Samin
