On 21 July 2023 03:09:19 IST, Guo Samin <samin.guo@xxxxxxxxxxxxxxxx> wrote: > > >-------- 原始信息 -------- >主题: Re: [PATCH v1 0/2] Add ethernet nodes for StarFive JH7110 SoC >From: Conor Dooley <conor@xxxxxxxxxx> >收件人: Conor Dooley <conor@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Albert Ou <aou@xxxxxxxxxxxxxxxxx>, Hal Feng <hal.feng@xxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, Samin Guo <samin.guo@xxxxxxxxxxxxxxxx> >日期: 2023/7/21 > >> From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> >> >> On Fri, 14 Jul 2023 18:45:19 +0800, Samin Guo wrote: >>> This series adds ethernet nodes for StarFive JH7110 RISC-V SoC, >>> and has been tested on StarFive VisionFive-2 v1.2A and v1.3B SBC boards. >>> >>> The first patch adds ethernet nodes for jh7110 SoC, the second patch >>> adds ethernet nodes for visionfive 2 SBCs. >>> >>> This series relies on xingyu's syscon patch[1]. >>> For more information and support, you can visit RVspace wiki[2]. >>> >>> [...] >> >> Applied to riscv-dt-for-next, thanks! >> >> [1/2] riscv: dts: starfive: jh7110: Add ethernet device nodes >> https://git.kernel.org/conor/c/1ff166c97972 >> [2/2] riscv: dts: starfive: visionfive 2: Add configuration of gmac and phy >> https://git.kernel.org/conor/c/b15a73c358d1 >> >> Thanks, >> Conor. > > >Hi Conor, > >Thank you so much! > >There is a question about the configuration of phy that I would like to consult you. > >Latest on motorcomm PHY V5[1]: Follow Rob Herring's advice >motorcomm,rx-xxx-driver-strength Changed to motorcomm,rx-xxx-drv-microamp . >V5 has already received a reviewed-by from Andrew Lunn, and it should not change again. > >Should I submit another pacthes based on riscv-dt-for-next? Huh, dtbs_check passed for these patches, I didn't realise changes to the motorcomm stuff were a dep. for this. I'll take a look later. > >[1] https://patchwork.kernel.org/project/netdevbpf/cover/20230720111509.21843-1-samin.guo@xxxxxxxxxxxxxxxx > > >Best regards, >Samin