On 2023/06/01 21:28, Andrew Lunn wrote: >>> Please could you add an explanation to the commit message why you >>> would want to do this? Is this because there is an LED connected to >>> it, but its polarity is inverted? >> >> Yes, the LINK_ST pin of AD1200/1300 is active-high but our custom >> board designer connected it to an LED as an active-low signal. > > O.K. LED is the magic word here. And the fact that there is nothing > specific to this PHY. Being able to specify the polarity of an output > to an LED is pretty common. > > Please take a look at: > > ocumentation/devicetree/bindings/net/ethernet-phy.yaml Thanks for your advice. But in this case, LINK_ST is also connected to MII_RXLINK pin of the MAC module in SoC. MII_RXLINK also expects low-active signal input. (though I only wrote about LED, sorry) AD1200/AD1200 have another LED_0 pin and it should be appropriate for the LED subsystem. So I still like to use this device specific property device. --- Atsushi Nemoto
