On 2023/05/31 23:35, Andrew Lunn wrote: >> The ADIN1200/ADIN1300 supports inverting the link status output signal >> on the LINK_ST pin. > > Please could you add an explanation to the commit message why you > would want to do this? Is this because there is an LED connected to > it, but its polarity is inverted? Yes, the LINK_ST pin of AD1200/1300 is active-high but our custom board designer connected it to an LED as an active-low signal. I'd like to change the description as follows: --- The ADIN1200/ADIN1300 supports inverting the link status output signal on the LINK_ST pin. The LINK_ST is active-high by default. This can be inverted by the GE_LNK_STAT_INV_REG register, meaning that link up is indicated by setting LINK_ST low. Add support for selecting this feature via device-tree properties. --- Atsushi Nemoto
