> But in this case, LINK_ST is also connected to MII_RXLINK pin of > the MAC module in SoC. MII_RXLINK also expects low-active signal input. > (though I only wrote about LED, sorry) This is why the Commit message should contain the answer to 'Why?'. The code tells us 'What', but without knowing the 'Why', it is hard to say if you are doing the right or wrong thing. O.K. so the signal is also connected to the SoC. Why? This is very unusual. The MAC does not really care if there is link or not, it just sends a bitstream to the PHY. phylib will be monitoring the PHY and when it detects the link is down it will tell the MAC via the adjust_link callback. What SoC is this? > AD1200/AD1200 have another LED_0 pin and it should be appropriate for > the LED subsystem. Agreed. Andrew
