On 1/11/23 10:55, Geert Uytterhoeven wrote:
> "make dtbs_check":
>
> arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dtb: clock-generator@6a: 'idt,shutdown' is a required property
> From schema: Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dtb: clock-generator@6a: 'idt,output-enable-active' is a required property
> From schema: Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
>
> Versaclock 5 clock generators can have their configuration stored in
> One-Time Programmable (OTP) memory. Hence there is no need to specify
> DT properties for manual configuration if the OTP has been programmed
> before. Likewise, the Linux driver does not touch the SD/OE bits if the
> corresponding properties are not specified, cfr. commit d83e561d43bc71e5
> ("clk: vc5: Add properties for configuring SD/OE behavior").
>
> Reflect this in the bindings by making the "idt,shutdown" and
> "idt,output-enable-active" properties not required, just like the
> various "idt,*" properties in the per-output child nodes.
IMO we should set this stuff explicitly.
> Fixes: 275e4e2dc0411508 ("dt-bindings: clk: vc5: Add properties for configuring the SD/OE pin")
This was intentional... not a fix IMO.
--Sean
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/clock/idt,versaclock5.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> index 61b246cf5e72aa47..a5472bbfb8d1fdcc 100644
> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> @@ -125,8 +125,6 @@ required:
> - compatible
> - reg
> - '#clock-cells'
> - - idt,shutdown
> - - idt,output-enable-active
>
> allOf:
> - if:
