Hi Geert,
On Wed, 11 Jan 2023 16:55:17 +0100
Geert Uytterhoeven <geert+renesas@xxxxxxxxx> wrote:
> "make dtbs_check":
>
> arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dtb: clock-generator@6a: 'idt,shutdown' is a required property
> From schema: Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dtb: clock-generator@6a: 'idt,output-enable-active' is a required property
> From schema: Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
>
> Versaclock 5 clock generators can have their configuration stored in
> One-Time Programmable (OTP) memory. Hence there is no need to specify
> DT properties for manual configuration if the OTP has been programmed
> before. Likewise, the Linux driver does not touch the SD/OE bits if the
> corresponding properties are not specified, cfr. commit d83e561d43bc71e5
> ("clk: vc5: Add properties for configuring SD/OE behavior").
>
> Reflect this in the bindings by making the "idt,shutdown" and
> "idt,output-enable-active" properties not required, just like the
> various "idt,*" properties in the per-output child nodes.
>
> Fixes: 275e4e2dc0411508 ("dt-bindings: clk: vc5: Add properties for configuring the SD/OE pin")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Thanks good catch!
Reviewed-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
