Dear Krzysztof, Thanks for your comment. On Mon, 2022-09-19 at 12:06 +0200, Krzysztof Kozlowski wrote: > On 19/09/2022 11:56, Jianguo Zhang wrote: > > > No, this does not justify new entry. You need specific > > > compatible, > > > but > > > not new entry. > > > > > > > On the other hand, mt8188 and mt8195 have same ethernet design, > > > > so > > > > the > > > > private data "mt8195_gmac_variant" can be resued to reduce > > > > redundant > > > > info in driver. > > > > > > And you do not need new entry in the driver. > > > > Do you mean that I can use "mediatek,mt8195-gmac" as compatible for > > ethernet in mt8188 DTS file? > > Yes, as a fallback. Example schema describes such case. > OK, we will drop the changes in patch #1 and add MT8188 related info in binding document in next version patches. > Best regards, > Krzysztof > BRS Jianguo
