Dear Krzysztof,
Thanks for your comments.
On Mon, 2022-09-19 at 10:19 +0200, Krzysztof Kozlowski wrote:
> On 19/09/2022 10:04, Jianguo Zhang wrote:
> > Add ethernet support for MediaTek SoCs from mt8188 family.
> > As mt8188 and mt8195 have same ethernet design, so private data
> > "mt8195_gmac_variant" can be reused for mt8188.
> >
> > Signed-off-by: Jianguo Zhang <jianguo.zhang@xxxxxxxxxxxx>
> > ---
> > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c
> > b/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c
> > index d42e1afb6521..f45be440b6d0 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c
> > @@ -720,6 +720,8 @@ static const struct of_device_id
> > mediatek_dwmac_match[] = {
> > .data = &mt2712_gmac_variant },
> > { .compatible = "mediatek,mt8195-gmac",
> > .data = &mt8195_gmac_variant },
> > + { .compatible = "mediatek,mt8188-gmac",
> > + .data = &mt8195_gmac_variant },
>
> It's the same. No need for new entry.
>
mt8188 and mt8195 are different SoCs and we need to distinguish mt8188
from mt8195, so I think a new entry is needed for mt8188 with the
specific "compatiable".
On the other hand, mt8188 and mt8195 have same ethernet design, so the
private data "mt8195_gmac_variant" can be resued to reduce redundant
info in driver.
>
> Best regards,
> Krzysztof
