On Wed, Jul 06, 2022 at 12:14:42PM +0200, Christian Marangi wrote:
> On Wed, Jul 06, 2022 at 10:39:16AM +0200, Krzysztof Kozlowski wrote:
> > On 05/07/2022 15:39, Christian Marangi wrote:
> > > Add missing smem node for ipq8064.
> > >
> > > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> > > Tested-by: Jonathan McDowell <noodles@xxxxxxxx>
> > > ---
> > > arch/arm/boot/dts/qcom-ipq8064.dtsi | 18 ++++++++++++++++++
> > > 1 file changed, 18 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > > index b5aede3d7ccf..98527a7d885e 100644
> > > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > > @@ -908,6 +908,11 @@ lcc: clock-controller@28000000 {
> > > #reset-cells = <1>;
> > > };
> > >
> > > + sfpb_mutex_block: syscon@1200600 {
> > > + compatible = "syscon";
> >
> > syscon alone is not allowed.
> >
>
> Mh... This is problematic. How this should be handled?
> This should be put in sfpb_mutex and change the driver to use regs if
> present instead of syscon?
>
Found an alternative solution used in ipq807x so I can drop the syscon
only node.
> > > + reg = <0x01200600 0x100>;
> > > + };
> > > +
> > > pcie0: pci@1b500000 {
> > > compatible = "qcom,pcie-ipq8064";
> > > reg = <0x1b500000 0x1000
> > > @@ -1332,4 +1337,17 @@ sdcc3: mmc@12180000 {
> > > };
> > > };
> > > };
> > > +
> > > + sfpb_mutex: sfpb-mutex {
> >
> > Generic node names, so hwlock
> >
> > > + compatible = "qcom,sfpb-mutex";
> > > + syscon = <&sfpb_mutex_block 4 4>;
> > > +
> > > + #hwlock-cells = <1>;
> > > + };
> > > +
> > > + smem {
> > > + compatible = "qcom,smem";
> > > + memory-region = <&smem>;
> > > + hwlocks = <&sfpb_mutex 3>;
> > > + };
> > > };
> >
> >
> > Best regards,
> > Krzysztof
>
> --
> Ansuel
--
Ansuel
