On Wed, 6 Jul 2022 at 13:31, Christian Marangi <ansuelsmth@xxxxxxxxx> wrote: > > On Wed, Jul 06, 2022 at 10:39:16AM +0200, Krzysztof Kozlowski wrote: > > On 05/07/2022 15:39, Christian Marangi wrote: > > > Add missing smem node for ipq8064. > > > > > > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx> > > > Tested-by: Jonathan McDowell <noodles@xxxxxxxx> > > > --- > > > arch/arm/boot/dts/qcom-ipq8064.dtsi | 18 ++++++++++++++++++ > > > 1 file changed, 18 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi > > > index b5aede3d7ccf..98527a7d885e 100644 > > > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi > > > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi > > > @@ -908,6 +908,11 @@ lcc: clock-controller@28000000 { > > > #reset-cells = <1>; > > > }; > > > > > > + sfpb_mutex_block: syscon@1200600 { > > > + compatible = "syscon"; > > > > syscon alone is not allowed. > > > > Mh... This is problematic. How this should be handled? > This should be put in sfpb_mutex and change the driver to use regs if > present instead of syscon? If nothing else works, you can add two compat strings, for example: "qcom,ipq8064-sfpb-mutex", "syscon"; This way if we add an sfpb driver at some point, we can still use old dts files. -- With best wishes Dmitry