> > + items: > > + - items: > > + - description: phandle for PMU system controller interface, used > to > > + control pmu registers bits for ufs m-phy > > Wrong indentation. This will be fixed on the next patchset. > > > + - description: offset of pmu control register for ufs m-phy > > + description: > > + can be phandle/offset pair. The offset can be optional. > > You made offset required, not optional. You need minItems:1 on the level > of second "items". Thanks. I didn't know how I make such that.. I'll apply this to next patchset. > > > > > required: > > - "#phy-cells" > > @@ -63,7 +68,7 @@ examples: > > compatible = "samsung,exynos7-ufs-phy"; > > reg = <0x15571800 0x240>; > > reg-names = "phy-pma"; > > - samsung,pmu-syscon = <&pmu_system_controller>; > > + samsung,pmu-syscon = <&pmu_system_controller 0x720>; This will be dropped as well. Best Regards, Chanho Park