RE: [PATCH 2/4] phy: samsung: ufs: support secondary ufs phy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +	u32 isol_offset;
> >  	int err = 0;
> >
> >  	match = of_match_node(samsung_ufs_phy_match, dev->of_node); @@
> > -328,7 +329,11 @@ static int samsung_ufs_phy_probe(struct
> platform_device *pdev)
> >  	phy->dev = dev;
> >  	phy->drvdata = drvdata;
> >  	phy->cfg = (struct samsung_ufs_phy_cfg **)drvdata->cfg;
> > -	phy->isol = &drvdata->isol;
> > +	phy->isol = (struct pmu_isol *)&drvdata->isol;
> 
> No casts are needed for proper code. If you need it - code is not proper.

To change a value of phy->isol, I need to allocate its own isol data and copying whole data from drvdata instead of using drvdata->isol pointer.

Best Regards,
Chanho Park





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux